When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well.
The OPAC detail page does currently show links to lists, but only to public lists. I don't think there's any reason why we shouldn't show links to private lists if the user is logged in.
Created attachment 128246 [details] [review] Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1
Created attachment 128247 [details] [review] Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1
Created attachment 128282 [details] [review] Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 128283 [details] [review] Bug 29621: (follow-up) Make all views consistent This follow-up makes various views more consistent: OPAC search results, OPAC details, staff search results, and staff details. The patch also adds an indication to the user which lists are private. To test, apply the patch and rebuild the OPAC and staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Repeat the previous test plan in the OPAC and staff client.
This is all working fine but the private lists add this bit: <span class="privateshelf">Private</span> which creates a display like this: Lists that include this title: list1 Private | list2 To me, that looks a little confusing. Would something like this be better? Lists that include this title: list1(Private) | list2 Also, lists are pipe separated on the detail page and comma separated on the results page. Should this be consistent? Maybe even make them CSS pseudo elements but perhaps we need Bug 27613 to get in first.
I see that there is different styling with the Private being no link, grey and italic, but I still feel some urge to add (). Maybe this would also be nicer for screen readers? Lists that include this title: list1 (Private) | list2
*** Bug 19342 has been marked as a duplicate of this bug. ***
Created attachment 130233 [details] [review] Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pierre Fagot <pierre.fagot@biblibre.com>
Created attachment 130234 [details] [review] Bug 29621: (follow-up) Make all views consistent This follow-up makes various views more consistent: OPAC search results, OPAC details, staff search results, and staff details. The patch also adds an indication to the user which lists are private. To test, apply the patch and rebuild the OPAC and staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Repeat the previous test plan in the OPAC and staff client. Signed-off-by: Pierre Fagot <pierre.fagot@biblibre.com>
I have executed the test plan everything is working.
catalogue/results.tt has a link to opac-shelves.pl I am not convinced by this enhancement. It is going to add extra processing for each record displayed in the search result. And this page is already too slow. Maybe it could be driven by a syspref, off by default?