Created attachment 128371 [details] [review] Bug 29668: Add API route to add a basket Example usage: POST /api/v1/acquisitions/baskets { "vendor_id": 1, "name": "Basket #1", } Test plan: 1. Try requesting this endpoint with your favorite API tool (I recommend https://github.com/frigus02/RESTer) 2. Run `prove t/db_dependent/api/v1/acquisitions_baskets/post.t`
This isn't compatible with the current master branch because of some changes in the api directory structure, but I think you already know. Some merge conflicts have to be resolved. There is the new route acquisitions/baskets/managers which probably wasn't there yet when this patch was written.
Must also be rebased now that Bug 38204 is in
Created attachment 183072 [details] [review] Bug 29668: Add API route to add a basket Example usage: POST /api/v1/acquisitions/baskets { "vendor_id": 1, "name": "Basket #1", } Test plan: 1. Try requesting this endpoint with your favorite API tool (I recommend https://github.com/frigus02/RESTer) 2. Run `prove t/db_dependent/api/v1/acquisitions_baskets/post.t` Edit (tcohen): Re-did the commit with some fixes in the spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 183073 [details] [review] Bug 29668: Move tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 183074 [details] [review] Bug 29668: Adapt to current guidelines The added patches make some changes: * $c->req->json is used to access the request body, as explained by the Mojolicious OpenAPI plugin author it should be done. * Instead of calling `$basket->to_api` we use the `$c->objects->to_api` helper which deals with calling context (embeds, etc). Otherwise it would require doing it manually if embeds are added. * Tests are grouped together the same way the rest of them are. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/acquisitions_baskets.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>