Created attachment 128463 [details] [review] Bug 29688: Incorrect use of _() in holds.js Bug 29404 moved code from request.tt into holds.js, and I didn't know about the _() vs. __(). This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Shouldn't we fix all the existing occurrences? background-job-progressbar.js: humanMsg.displayMsg( '<p>' + _('Import of record(s) failed: ') + textStatus + '</p></br>'+xml.responseText, { className: 'humanError' } ); calendar.js: is_date_after: _("Validation error to be shown, i.e. End date must come after start date") checkouts.js: $(selected_option).text(_("%s (current status)").format($(selected_option).text())); datatables.js: var search_title = _("%s search").format(title); holds.js: _("This pickup location is not allowed according to circulation rules") + letter.js: $(sms_counter).html(length + "/" + sms_limit + _(" characters")); onboarding.js:function _(s) { return s; } // dummy function for gettext pages/results.js: div.find(".hint").html(_("Coce image from Amazon.com")); pages/results.js: div.find(".hint").html(_("Coce image from Google Books")); pages/results.js: div.find(".hint").html(_("Coce image from Open Library")); pages/tags-review.js: // window.alert(_("AJAX approved tag: ") + tag); pages/tags-review.js: // window.alert(_("AJAX rejected tag: ") + tag); pages/tags-review.js: $('#test_button').html("<i class='fa fa-check-square-o' aria-hidden='true'></i>" +_(" Test")); pages/tags-review.js: // window.alert(_("Click detected on ") + event.target + ": " + $(event.target).html); rotating-collections.js: if(confirm(_("Are you sure you want to delete this rotating collection?"))){ xmlControlfield.js: alert(_("AJAX error: receiving data from %s").format(settings.url));
I've split the other appearances Joubu found into a separate bug 29831 so this can be pushed before string freeze.
Created attachment 129234 [details] [review] Bug 29688: Incorrect use of _() in holds.js Bug 29404 moved code from request.tt into holds.js, and I didn't know about the _() vs. __(). This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Moving directly to PQA.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Missing dependency, not backported to 21.05