While working on Bug 29280 I noticed there is some different code related to OpacStarRatings that could be consolidated a bit. OPAC pages that include OpacStarRatings are: -OPAC detail -OPAC user summary -OPAC reading history -OPAC results Sometimes a logged in user can interact with the ratings (OPAC detail, user summary, reading history ) Other times they cannot ( results ) A bit of cleanup here can make it easier to implement OPACStarRatigs elsewhere, like on the list displays in Bug 29280.
Created attachment 128850 [details] [review] Bug 29749: Clean up OpacStarRatings code To test: 1. Apply patch 2. Make sure OpacStarRatings is set to 'results, details, patrons' 3. Check out some items to a patron you can login to the OPAC as 4. Do a OPAC catalog search that will turn up some of those items you checked out 5. Go to the item's detail pages, logged in as the patron with those checkouts 6. From the detail page, rate some of those items. 7. Go to the user summary page, make sure you can see and change the ratings from there. 8. Go to the reading history page, make sure you can see and change those ratins from there. 9. Go back to the detail pages and make sure any changes you made on the user summary and reading history page are acuratly reflected 10. Look at those items from the results page. You should be able to view the ratings but not change them. 11. Again visit the OPAC, this time as a unauthenticated user. You should be able to view the ratings from the details page but not interact with them.
Lucas, is this patch ready for testing?
Created attachment 132067 [details] [review] Bug 29749: Clean up OpacStarRatings code To test: 1. Apply patch 2. Make sure OpacStarRatings is set to 'results, details, patrons' 3. Check out some items to a patron you can login to the OPAC as 4. Do a OPAC catalog search that will turn up some of those items you checked out 5. Go to the item's detail pages, logged in as the patron with those checkouts 6. From the detail page, rate some of those items. 7. Go to the user summary page, make sure you can see and change the ratings from there. 8. Go to the reading history page, make sure you can see and change those ratins from there. 9. Go back to the detail pages and make sure any changes you made on the user summary and reading history page are acuratly reflected 10. Look at those items from the results page. You should be able to view the ratings but not change them. 11. Again visit the OPAC, this time as a unauthenticated user. You should be able to view the ratings from the details page but not interact with them.
Is this patch ready for testing?