Found the following warning in plack intranet error log: CGI::param called in list context from boraccount.pl line 58, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412.
Just kinda feels like something we should fix, yknow? :)
Created attachment 128907 [details] [review] Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 128940 [details] [review] Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 129192 [details] [review] Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.11
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.