Bug 29779 - selenium/regressions.t fails if Selenium lib is not installed
Summary: selenium/regressions.t fails if Selenium lib is not installed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-03 11:33 UTC by Jonathan Druart
Modified: 2022-06-06 20:31 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00,21.11.03


Attachments
Bug 29779: Make selenium tests return green even if lib is missing (6.16 KB, patch)
2022-01-03 11:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29779: Make selenium tests return green even if lib is missing (6.21 KB, patch)
2022-01-19 15:17 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-01-03 11:33:31 UTC
t/db_dependent/selenium/regressions.t .. 1/7 Label not found for "last SKIP" at /usr/share/perl/5.28/Test/More.pm line 1370.
Comment 1 Jonathan Druart 2022-01-03 11:40:07 UTC
Created attachment 128958 [details] [review]
Bug 29779: Make selenium tests return green even if lib is missing

Some selenium tests are not correctly written and they fail is
Selenium::Remote::Driver is missing.

Test plan:
1. Remove the lib rm `pmpath Selenium::Remote::Driver`
2. prove t/db_dependent/selenium/
should return green
Comment 2 Martin Renvoize 2022-01-19 15:17:11 UTC
Created attachment 129615 [details] [review]
Bug 29779: Make selenium tests return green even if lib is missing

Some selenium tests are not correctly written and they fail is
Selenium::Remote::Driver is missing.

Test plan:
1. Remove the lib rm `pmpath Selenium::Remote::Driver`
2. prove t/db_dependent/selenium/
should return green

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2022-01-19 15:17:48 UTC
All works as expected for me.. signing off.
Comment 4 Jonathan Druart 2022-01-27 15:22:26 UTC
Trivial, skipping QA.
Comment 5 Fridolin Somers 2022-02-01 07:57:10 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 6 Kyle M Hall 2022-02-07 16:37:32 UTC
Pushed to 21.11.x for 21.11.03
Comment 7 Fridolin Somers 2022-02-11 19:10:57 UTC
Test was failing :
https://jenkins.koha-community.org/view/master/job/Koha_Master/1910/

Commit in master :
090c70b746 Bug 29779: Fix unit tests count

Also in 21.11.x :
4729fd7881 Bug 29779: Fix unit tests count for 21.11.x