If the deletion of a serial item failed, the UI does not provide a warning/error message.
Created attachment 128992 [details] [review] Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time."
Created attachment 129006 [details] [review] Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 129168 [details] [review] Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time." Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
With this patch applied to 21.05.x, following the test plan, the issue is deleted but the item is not and I receive no error message. I see no change in behavior with or without the patch. Jonathan, can you take a look? I'm happy to backport, but this doesn't seem to do the trick.