Bug 29793 - Commenting "listen" biblioserver in KOHA_CONF crashes about.pl
Summary: Commenting "listen" biblioserver in KOHA_CONF crashes about.pl
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Zebra (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-04 18:51 UTC by Lari Taskula
Modified: 2022-01-05 08:13 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2022-01-04 18:51:16 UTC
To replicate:
1. Comment out or delete <listen id="biblioserver">...</listen> from your Koha config file
2. Navigate to staff client /cgi-bin/koha/about.pl
3. Observe error 500
4. Check error logs, see
Can't use an undefined value as a HASH reference at C4/Context.pm line 536.

Question: If you are using ElasticSearch, is it still necessary to have Zebra related configurations in KOHA_CONF?

Bug appears after Bug 28306 commit 4605304f62228172be094393875625b1e9666bda
Comment 1 Lari Taskula 2022-01-04 18:52:37 UTC
(In reply to Lari Taskula from comment #0)
> Can't use an undefined value as a HASH reference at C4/Context.pm line 536.

The correct line as of 442fb97155285ff4063cdd6279328ebed62ea6d4 is 534 not 536.
Comment 2 Fridolin Somers 2022-01-05 08:13:52 UTC
I'd say we move this code into the eval:

    my $host = _common_config($server, 'listen')->{content};
    my $serverinfo = _common_config($server, 'serverinfo');
    my $user = $serverinfo->{user};
    my $password = $serverinfo->{password};