This method incorrectly converts the underlying resultset into an arrayref.
Created attachment 130105 [details] [review] Bug 29847: Make Koha::Patron::HouseboundProfile->housebound_visits return a resultset This patch makes the method consistent with the rest of the codebase, by making it return a proper resultset. To test: 1. Run: $ kshell k$ prove t/db_dependent/Patron/HouseboundProfiles.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Check the UI hasn't got broken either. => SUCCESS: It hasn't! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
OOh, thanks for jumping on this Tomas.. I'll have a look today :)
Created attachment 130140 [details] [review] Bug 29847: Make Koha::Patron::HouseboundProfile->housebound_visits return a resultset This patch makes the method consistent with the rest of the codebase, by making it return a proper resultset. To test: 1. Run: $ kshell k$ prove t/db_dependent/Patron/HouseboundProfiles.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Check the UI hasn't got broken either. => SUCCESS: It hasn't! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Tests passing, QA script happy and functionality unaffected.. all working great. Going straight for QA on this trivial improvement. Pass
Pushed to master for 22.05, thanks to everybody involved [U+1F984]