Currently, this syspref reads "Patrons can only have (X) holds at once." I would update that to: "Patrons can have a maximum of (X) holds at once. Leave blank or set to zero to disable." I've just confirmed this behavior on master: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron We've got discussion of this syspref generally over in 25643, but unless we're moving it in the near future we should at least make it clear and accurate.
+1
Created attachment 129437 [details] [review] Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron
Created attachment 129443 [details] [review] Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron
Created attachment 129444 [details] [review] Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron
Added a sentence: "Additional limits may apply based on circulation rules."
Created attachment 129455 [details] [review] Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Andrew Fuerste-Henry from comment #5) > Added a sentence: "Additional limits may apply based on circulation rules." Great. Hope Katrin signs it so it can be added before string freeze!
Created attachment 129463 [details] [review] Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.14
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.