Bug 29887 - Create system preference IndependentBranchesLoggedInLibrary
Summary: Create system preference IndependentBranchesLoggedInLibrary
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 30387
Blocks: 30624
  Show dependency treegraph
 
Reported: 2022-01-14 16:57 UTC by Lucas Gass
Modified: 2022-04-28 16:50 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary (8.56 KB, patch)
2022-01-14 22:17 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: database update (1.51 KB, patch)
2022-01-14 22:34 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: (follow-up) show all branches to non superlibraians (1.05 KB, patch)
2022-02-10 16:07 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary (8.61 KB, patch)
2022-02-16 17:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 29887: database update (1.55 KB, patch)
2022-02-16 17:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 29887: (follow-up) show all branches to non superlibraians (1.10 KB, patch)
2022-02-16 17:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 29887: (follow-up) Create a system pref category for Independent branches (4.60 KB, patch)
2022-03-04 15:39 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary (5.89 KB, patch)
2022-03-28 17:10 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: database update (1.55 KB, patch)
2022-03-28 17:10 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: (follow-up) show all branches to non superlibraians (1.10 KB, patch)
2022-03-28 17:10 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29887: (follow-up) Create a system pref category for Independent branches (4.60 KB, patch)
2022-03-28 17:10 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-01-14 16:57:41 UTC
Currently if IndependentBranches is turned on it makes it so staff cannot switch branches or 'Set library' unless they are a superlibrarian. 

Some libraries like this aspect of IndependentBranches but don't want everything else that comes with turning on IndependentBranches. 

A new system pref 'IndependentBranchesLoggedInLibrary' would allow libraries to utilize this aspect of IndependentBranches without having to turn on everything else that comes with that system preference.
Comment 1 Lucas Gass 2022-01-14 22:17:46 UTC
Created attachment 129517 [details] [review]
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary

To test:
1. Have a user who has staff access and circulate privileges but is not a super librarian
2. Apply the patches and run updatedatabase.pl
3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes.
4. Also turn on the system preference 'CircSidebar'
5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch.
6. Log in as the non-superlibrarian.
7. In the top left hand corner notice you are logged in under that users homebranch.
8. Click the dropdown, there is no link for 'Set library'.
9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation'
10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages.
11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch
12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes.
13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links.
14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No
15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches
Comment 2 Lucas Gass 2022-01-14 22:34:48 UTC
Created attachment 129518 [details] [review]
Bug 29887: database update
Comment 3 Andrew Fuerste-Henry 2022-02-09 20:51:53 UTC
In step 15, my non-superlibrarian user can access the Set Library feature, but is presented with a dropdown that only offers their current library.
Comment 4 Lucas Gass 2022-02-10 16:07:38 UTC
Created attachment 130452 [details] [review]
Bug 29887: (follow-up) show all branches to non superlibraians
Comment 5 Andrew Fuerste-Henry 2022-02-16 17:16:00 UTC
Created attachment 130674 [details] [review]
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary

To test:
1. Have a user who has staff access and circulate privileges but is not a super librarian
2. Apply the patches and run updatedatabase.pl
3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes.
4. Also turn on the system preference 'CircSidebar'
5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch.
6. Log in as the non-superlibrarian.
7. In the top left hand corner notice you are logged in under that users homebranch.
8. Click the dropdown, there is no link for 'Set library'.
9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation'
10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages.
11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch
12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes.
13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links.
14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No
15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 6 Andrew Fuerste-Henry 2022-02-16 17:16:04 UTC
Created attachment 130675 [details] [review]
Bug 29887: database update

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 7 Andrew Fuerste-Henry 2022-02-16 17:16:08 UTC
Created attachment 130676 [details] [review]
Bug 29887: (follow-up) show all branches to non superlibraians

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 8 Jonathan Druart 2022-02-21 15:16:45 UTC
Isn't the syspref's name misleading? Shouldn't it be more something like "prevent staff to change their logged in library"?
Comment 9 Katrin Fischer 2022-02-21 20:10:22 UTC
I think the confusing bit could be it having "independentbranches" when it doesn't depend on the pref itself. But we also have IndependentBranchesPatronModifications that doesn't depend on it. So the situation is not really clear.

Maybe: AllowStaffChangeLoggedInBranch ?

(too long?)
Comment 10 Nick Clemens 2022-02-22 12:52:28 UTC
(In reply to Katrin Fischer from comment #9)
> I think the confusing bit could be it having "independentbranches" when it
> doesn't depend on the pref itself. But we also have
> IndependentBranchesPatronModifications that doesn't depend on it. So the
> situation is not really clear.
> 
> Maybe: AllowStaffChangeLoggedInBranch ?
> 
> (too long?)

The idea with this pref, and IndependentBranchesPatronModifications is that they were once a part of 'IndependentBranches'

The goal is to make that preference more granular and allow libraries to set parts of it without others, and keeping them all related with 'IndependentBranches' in the name - possibly it could be a category for the prefs?
Comment 11 Katrin Fischer 2022-02-22 22:42:16 UTC
(In reply to Nick Clemens from comment #10)
> (In reply to Katrin Fischer from comment #9)
> > I think the confusing bit could be it having "independentbranches" when it
> > doesn't depend on the pref itself. But we also have
> > IndependentBranchesPatronModifications that doesn't depend on it. So the
> > situation is not really clear.
> > 
> > Maybe: AllowStaffChangeLoggedInBranch ?
> > 
> > (too long?)
> 
> The idea with this pref, and IndependentBranchesPatronModifications is that
> they were once a part of 'IndependentBranches'
> 
> The goal is to make that preference more granular and allow libraries to set
> parts of it without others, and keeping them all related with
> 'IndependentBranches' in the name - possibly it could be a category for the
> prefs?

I like the idea of making it a category and we should maybe note in the description it works independently from Independentbranches? I am ok with the pref name as is.
Comment 12 Lucas Gass 2022-03-02 16:12:24 UTC
> I like the idea of making it a category and we should maybe note in the
> description it works independently from Independentbranches? I am ok with
> the pref name as is.

Cait, can you explain what is meant by "category"? I don't understand.
Comment 13 Lucas Gass 2022-03-04 15:39:37 UTC
Created attachment 131380 [details] [review]
Bug 29887: (follow-up) Create a system pref category for Independent branches
Comment 14 Katrin Fischer 2022-03-05 22:58:30 UTC
(In reply to Lucas Gass from comment #13)
> Created attachment 131380 [details] [review] [review]
> Bug 29887: (follow-up) Create a system pref category for Independent branches

Was referring to your comment there :)
Comment 15 Lucas Gass 2022-03-28 17:10:36 UTC
Created attachment 132353 [details] [review]
Bug 29887: Add system preference IndependentBranchesLoggedInLibrary

To test:
1. Have a user who has staff access and circulate privileges but is not a super librarian
2. Apply the patches and run updatedatabase.pl
3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes.
4. Also turn on the system preference 'CircSidebar'
5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch.
6. Log in as the non-superlibrarian.
7. In the top left hand corner notice you are logged in under that users homebranch.
8. Click the dropdown, there is no link for 'Set library'.
9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation'
10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages.
11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch
12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes.
13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links.
14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No
15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 16 Lucas Gass 2022-03-28 17:10:40 UTC
Created attachment 132354 [details] [review]
Bug 29887: database update

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 17 Lucas Gass 2022-03-28 17:10:43 UTC
Created attachment 132355 [details] [review]
Bug 29887: (follow-up) show all branches to non superlibraians

Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Comment 18 Lucas Gass 2022-03-28 17:10:47 UTC
Created attachment 132356 [details] [review]
Bug 29887: (follow-up) Create a system pref category for Independent branches
Comment 19 Lucas Gass 2022-03-28 17:11:31 UTC
rebased changes from Bug 30387 on to this patchset
Comment 20 Katrin Fischer 2022-04-24 11:40:31 UTC
This is currently BLOCKED by the depenency requiring sign-off.