Currently if IndependentBranches is turned on it makes it so staff cannot switch branches or 'Set library' unless they are a superlibrarian. Some libraries like this aspect of IndependentBranches but don't want everything else that comes with turning on IndependentBranches. A new system pref 'IndependentBranchesLoggedInLibrary' would allow libraries to utilize this aspect of IndependentBranches without having to turn on everything else that comes with that system preference.
Created attachment 129517 [details] [review] Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches
Created attachment 129518 [details] [review] Bug 29887: database update
In step 15, my non-superlibrarian user can access the Set Library feature, but is presented with a dropdown that only offers their current library.
Created attachment 130452 [details] [review] Bug 29887: (follow-up) show all branches to non superlibraians
Created attachment 130674 [details] [review] Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 130675 [details] [review] Bug 29887: database update Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 130676 [details] [review] Bug 29887: (follow-up) show all branches to non superlibraians Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Isn't the syspref's name misleading? Shouldn't it be more something like "prevent staff to change their logged in library"?
I think the confusing bit could be it having "independentbranches" when it doesn't depend on the pref itself. But we also have IndependentBranchesPatronModifications that doesn't depend on it. So the situation is not really clear. Maybe: AllowStaffChangeLoggedInBranch ? (too long?)
(In reply to Katrin Fischer from comment #9) > I think the confusing bit could be it having "independentbranches" when it > doesn't depend on the pref itself. But we also have > IndependentBranchesPatronModifications that doesn't depend on it. So the > situation is not really clear. > > Maybe: AllowStaffChangeLoggedInBranch ? > > (too long?) The idea with this pref, and IndependentBranchesPatronModifications is that they were once a part of 'IndependentBranches' The goal is to make that preference more granular and allow libraries to set parts of it without others, and keeping them all related with 'IndependentBranches' in the name - possibly it could be a category for the prefs?
(In reply to Nick Clemens from comment #10) > (In reply to Katrin Fischer from comment #9) > > I think the confusing bit could be it having "independentbranches" when it > > doesn't depend on the pref itself. But we also have > > IndependentBranchesPatronModifications that doesn't depend on it. So the > > situation is not really clear. > > > > Maybe: AllowStaffChangeLoggedInBranch ? > > > > (too long?) > > The idea with this pref, and IndependentBranchesPatronModifications is that > they were once a part of 'IndependentBranches' > > The goal is to make that preference more granular and allow libraries to set > parts of it without others, and keeping them all related with > 'IndependentBranches' in the name - possibly it could be a category for the > prefs? I like the idea of making it a category and we should maybe note in the description it works independently from Independentbranches? I am ok with the pref name as is.
> I like the idea of making it a category and we should maybe note in the > description it works independently from Independentbranches? I am ok with > the pref name as is. Cait, can you explain what is meant by "category"? I don't understand.
Created attachment 131380 [details] [review] Bug 29887: (follow-up) Create a system pref category for Independent branches
(In reply to Lucas Gass from comment #13) > Created attachment 131380 [details] [review] [review] > Bug 29887: (follow-up) Create a system pref category for Independent branches Was referring to your comment there :)
Created attachment 132353 [details] [review] Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 132354 [details] [review] Bug 29887: database update Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 132355 [details] [review] Bug 29887: (follow-up) show all branches to non superlibraians Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Created attachment 132356 [details] [review] Bug 29887: (follow-up) Create a system pref category for Independent branches
rebased changes from Bug 30387 on to this patchset
This is currently BLOCKED by the depenency requiring sign-off.
Moving this back to BLOCKED until we have resolved bug 30387. I think both together make a lot of sense and hope to see them moving!
Since we need to move this logic from the system preference IndependentBranchesLoggedInLibrary into a permission, I am resolving this bug and will work on adding the permission in Bug 30624.