Bug 29890 - Unprivileged route to bib records needs check on OpacSuppression
Summary: Unprivileged route to bib records needs check on OpacSuppression
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 24909
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-15 13:14 UTC by Katrin Fischer
Modified: 2022-01-19 04:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-01-15 13:14:12 UTC 
Filed because of David's comment on bug 24909:

The unprivileged route for bibliographic records needs to take OpacSuppression into account.
Comment 1 David Cook 2022-01-17 02:08:57 UTC 
Thanks, Katrin. I'm a bit overwhelmed by all the different places that need to take into account things like OpacSuppression and OpacHideItems...
Comment 2 Fridolin Somers 2022-01-18 06:42:56 UTC 
For OpacHideItems, create a new report depending on Bug 24403 omnibus
Comment 3 Fridolin Somers 2022-01-18 06:44:20 UTC 
I hope our open-source ILS is mainly used for 100% open-data ;)
Comment 4 David Cook 2022-01-19 01:12:07 UTC 
(In reply to Fridolin Somers from comment #3)
> I hope our open-source ILS is mainly used for 100% open-data ;)

Hahahaha
Comment 5 David Cook 2022-01-19 01:15:47 UTC 
(In reply to Fridolin Somers from comment #2)
> For OpacHideItems, create a new report depending on Bug 24403 omnibus

I don't think I have a report at the moment.

I think Tomas has made progress on creating functions to handle OpacHideItems via the Koha::Biblio object, so that's good. OpacSuppression really needs an equivalent. (I think there might also be some performance limitations to the OpacHideItems calculation, but I'm probably not going to work on them...and I'd need to do some profiling to even prove that those limitations exist...)
Comment 6 Tomás Cohen Arazi (tcohen) 2022-01-19 03:18:11 UTC 
(In reply to Fridolin Somers from comment #2)
> For OpacHideItems, create a new report depending on Bug 24403 omnibus

https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/REST/V1/Biblios.pm#L178
Comment 7 David Cook 2022-01-19 03:58:54 UTC 
(In reply to Tomás Cohen Arazi from comment #6)
> (In reply to Fridolin Somers from comment #2)
> > For OpacHideItems, create a new report depending on Bug 24403 omnibus
> 
> https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/
> REST/V1/Biblios.pm#L178

I've been thinking we could just extend "hidden_in_opac" to include OpacSuppression as well. That might be a better name for this bug report really...
Comment 8 David Cook 2022-01-19 04:00:52 UTC 
I have wondered a bit about OpacSuppressionByIPRange with an API although I don't know how much that is used. We don't have stats on it on Hea due to the private nature of the values I think...