Bug 29904 - Serials: Clear 'Automatically set to late' when changing status
Summary: Serials: Clear 'Automatically set to late' when changing status
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-19 12:29 UTC by Marcel de Rooy
Modified: 2024-09-26 12:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-01-19 12:29:19 UTC
Yes it takes about half a second to clear it, but wouldnt it be marvelous when Koha would do it rightaway?

And if we do this a million times, we win 500.000 seconds ! 138 hours !
We could signoff so much more patches :)
Comment 1 Katrin Fischer 2022-01-20 21:42:08 UTC
I didn't need to be persuaded. Maybe the only problem I see is that the note is set on the command line - so how can we tell the auto notes from other manually added notes?

Or would it be a more general "empty note when the late status is changed"?
Comment 2 Marcel de Rooy 2022-01-21 07:08:07 UTC
(In reply to Katrin Fischer from comment #1)
> I didn't need to be persuaded. Maybe the only problem I see is that the note
> is set on the command line - so how can we tell the auto notes from other
> manually added notes?
> 
> Or would it be a more general "empty note when the late status is changed"?

git grep 'Automatically set to late'
misc/cronjobs/serialsUpdate.pl:   --note          Note set on affected serial issues, by default "Automatically set to late"
misc/cronjobs/serialsUpdate.pl:    $note = 'Automatically set to late';

Good point, Katrin.
I would not opt for always clearing the note.
This leaves us matching with either the default note or a set of strings from a preference or so?
Comment 3 Katrin Fischer 2022-01-21 08:47:11 UTC
We are using a German note, so the pref approach would make me happier :)
Comment 4 Esther Melander 2024-05-03 19:02:13 UTC
This note appears to be tied to a serial status, so it would be nice if it disappeared when received. However, there is no way to customize the text of this note, nor the ability to control whether it should appear or not at all. One library would prefer the note field remain blank, even for late issues.

The note box in serial receiving is also used as a free text box. But it is not made clear this note is a public note and will show in the OPAC. The only way to control the visibility of the note in the OPAC is to delete the note on receiving. There should be options on visibility here. Or perhaps it should not show at all and the 952$z should be the only public facing note field.
Comment 5 Katrin Fischer 2024-05-03 19:34:34 UTC
(In reply to Esther Melander from comment #4)
> This note appears to be tied to a serial status, so it would be nice if it
> disappeared when received. However, there is no way to customize the text of
> this note, nor the ability to control whether it should appear or not at
> all. One library would prefer the note field remain blank, even for late
> issues.

This is not quite true. It's tied to the serialsUpdate cron job and can be customized/configured there. I looked into it as we didn't want to set the note any longer, only the Late status.

https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/cronjobs/serialsUpdate.pl
   --no-note       Do not set a note on affected serial issues

> The note box in serial receiving is also used as a free text box. But it is
> not made clear this note is a public note and will show in the OPAC. The
> only way to control the visibility of the note in the OPAC is to delete the
> note on receiving. There should be options on visibility here. Or perhaps it
> should not show at all and the 952$z should be the only public facing note
> field.

I once filed a bug that we should create another note field for serial issues, so we can have an internal and a public one. Not all libraries are creating serial items and they like to add things like + CD in the note field. I think there is a need for a public one too.