Bug 29911 - Default amounts for fee types display with comma in some cases
Summary: Default amounts for fee types display with comma in some cases
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-01-20 08:30 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-01-20 08:30:34 UTC
When CurrencyFormat is set to "FR" and you are manually adding a copier fee or similar to a patron account, the amount will show up with a decimal comma instead of a decimal dot, which won't work correctly.

This is because we are missing the on_editing => 1 filter here:

maninvoice.tt

    <script>
        var type_fees = {};
        [% FOREACH debit_type IN debit_types %]
            type_fees['[% debit_type.code | html %]'] = "[% IF debit_type.default_amount %][% debit_type.default_amount | $Price %][% END %]";
Comment 1 Katrin Fischer 2023-01-02 18:30:36 UTC
It appears this was meanwhile fixed on another bug :)