If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked: Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060. at /kohadevbox/koha/C4/Reserves.pm line 1057 C4::Reserves::ModReserve('HASH(0x5583dff297d8)') called at /kohadevbox/koha/reserve/modrequest.pl line 87
Created attachment 129948 [details] [review] Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary)
Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort".
Created attachment 129990 [details] [review] Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary)
Created attachment 130017 [details] [review] Bug 29969: Prevent crash if 'Update holds' clicked after bulk cancellation If you cancel holds in bulk, the list is not updated as we enqueued the task. But the "Update hold(s)" button will explode if clicked. Test plan: Place several holds on a bib record Use the "Cancel selected" link to cancel holds in bulk The job is enqueued and the hold list still show the holds you cancelled Click "Update holds" => Without this patch you get an ugly 500 Can't call method "found" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1060 => With this patch applied the table is refresh, no crash (and there is a warning in the log, that may not be necessary) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 130865 [details] [review] Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC The method Koha::AuthorisedValues->authorised_value is not covered by tests! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Nick Clemens from comment #5) > Created attachment 130865 [details] [review] [review] > Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC > > The method Koha::AuthorisedValues->authorised_value is not covered by tests! > > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > > Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Ich, wrong bug Nick :D
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Missing dependency, not backported to 21.05