Not sure why, but I forgot to add this method earlier on the bug tree. Needed for consistency and completion of the refactoring.
Created attachment 130161 [details] [review] Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D
Created attachment 130162 [details] [review] Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D
Created attachment 130178 [details] [review] Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com>
Created attachment 130179 [details] [review] Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com>
Created attachment 130277 [details] [review] Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 130278 [details] [review] Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All works as designed and clarifies the code. Tested, and QA scripts happy. Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]