Created attachment 130607 [details] [review] Bug 30094: Make the patron search from request-article.pl use the REST API Reuse what has been done before to implement the patron search using the REST API route, when requesting an article Test plan: Request an article for a patron and confirm that the search is working correctly.
Created attachment 132543 [details] [review] Bug 30094: Make the patron search from request-article.pl use the REST API Reuse what has been done before to implement the patron search using the REST API route, when requesting an article Test plan: Request an article for a patron and confirm that the search is working correctly.
Created attachment 132689 [details] [review] Bug 30094: Make the patron search from request-article.pl use the REST API Reuse what has been done before to implement the patron search using the REST API route, when requesting an article Test plan: Request an article for a patron and confirm that the search is working correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Sorry Jonathan, same QA failure here as the previous one: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 439)
Created attachment 132729 [details] [review] Bug 30094: Make the patron search from request-article.pl use the REST API Reuse what has been done before to implement the patron search using the REST API route, when requesting an article Test plan: Request an article for a patron and confirm that the search is working correctly. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132730 [details] [review] Bug 30094: (QA follow-up) Mke the QA script happy Remove newlines from a template block Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I added the QA follow-up.. Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]