In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. We should have the same behavior in SIP, for consistency.
Created attachment 130703 [details] [review] Bug 30118: Make holds_block_checkin in SIP behave like in Koha interface. In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. This patch does the same in SIP: the return is blocked when holds_block_checkin is enabled and there is a hold on a specific item and this is the very item being returned. Test plan: The following behavior is expected in SIP: - An item is returned, and there is a reservation on record-level: block - An item is returned, and there is a reservation on this very item: block - An item is returned, and there is a reservation on another item: allow
Created attachment 132626 [details] [review] Bug 30118: Make holds_block_checkin in SIP behave like in Koha interface. In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. This patch does the same in SIP: the return is blocked when holds_block_checkin is enabled and there is a hold on a specific item and this is the very item being returned. Test plan: The following behavior is expected in SIP: - An item is returned, and there is a reservation on record-level: block - An item is returned, and there is a reservation on this very item: block - An item is returned, and there is a reservation on another item: allow Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Hi, I tried on my kohadevbox with ./sip_cli_emulator.pl I've followed the test plan and it works: For a reservation at a biblio-level, for the first item returned that is going to fulfill the reservation : it is blocked For a reservation at a biblio-level, if an item is already waiting for to fulfill the reservation, if you checkin another item : it is not blocked For a reservation at an item level, if you checkin another item : it is not blocked For a reservation at item level, if you checkin the very item : it is blocked Sonia
Created attachment 132656 [details] [review] Bug 30118: Make holds_block_checkin in SIP behave like in Koha interface. In koha interface, a warning is displayed when an item on hold is returned only if the return is for this specific item. This patch does the same in SIP: the return is blocked when holds_block_checkin is enabled and there is a hold on a specific item and this is the very item being returned. Test plan: The following behavior is expected in SIP: - An item is returned, and there is a reservation on record-level: block - An item is returned, and there is a reservation on this very item: block - An item is returned, and there is a reservation on another item: allow Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 132657 [details] [review] Bug 30118: (QA follow-up) Fix Perl Critic issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05
Pushed to 21.05.x for 21.05.14
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.