Bug 30122 - Display note fields in authority result list
Summary: Display note fields in authority result list
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-17 15:25 UTC by Jonathan Druart
Modified: 2022-11-17 12:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 30122: Display note fields in authority result list (1.39 KB, patch)
2022-02-17 15:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-02-17 15:25:30 UTC

    
Comment 1 Jonathan Druart 2022-02-17 15:30:19 UTC
Created attachment 130761 [details] [review]
Bug 30122: Display note fields in authority result list

The note fields are displayed for UNIMARC only.

Test plan:
Add some note fields to an authority record, search for it and confirm
that the notes are now display in the authority result list

Sponsored-by: Orex Digital
Comment 2 Jonathan Druart 2022-02-17 15:30:47 UTC
Do we really need this?
Comment 3 Katrin Fischer 2022-02-19 13:47:34 UTC
How and where are the note fields added?
Comment 4 Jonathan Druart 2022-02-21 12:04:58 UTC
(In reply to Katrin Fischer from comment #3)
> How and where are the note fields added?

The "notes" are retrieved from BuildSummary using 600 (for MARC21)

1015         foreach my $field ($record->field('6..')) {
1016             push @notes, { note => $field->as_string(), field => $field->tag() };
1017         }

They are added at the bottom of the other authority's summary info.
Comment 5 Katrin Fischer 2022-02-21 22:23:11 UTC
I am not sure about this one, it looks like actual notes are only 667-688.

I wonder if it could not make the entries in the results list a little too lenghty. But I see that there is a class to hide.

How are we doing performance wise here?
Comment 6 Katrin Fischer 2022-02-21 22:23:32 UTC
Meant to add the link as well:
https://www.loc.gov/marc/authority/ad66768x.html
Comment 7 Jonathan Druart 2022-02-22 08:21:19 UTC
(In reply to Katrin Fischer from comment #5)
> I am not sure about this one, it looks like actual notes are only 667-688.

It's the current that is retrieving 6.. I need to check if it's used somewhere else.

> I wonder if it could not make the entries in the results list a little too
> lenghty. But I see that there is a class to hide.

Could be a syspref otherwise.

> How are we doing performance wise here?

No change is done in the logic, we retrieve them (but don't use them) already.

Will get back to it later.
Comment 8 Hugo Agud 2022-02-22 09:00:21 UTC
I think that it is necessary to be able to select what tags to publish, as there are some notes that are automatically created and not provide useful informationn, for example 667 automatica creation, it doesn't gives useful information for users

syspref for selecting what to publish from notes? if none selected, publish nothing
Comment 9 Jonathan Druart 2022-04-22 12:33:09 UTC
We are displaying the notes at the OPAC, on the detail page of the authority.

I think I am identifying 2 different needs here, one is to display the notes on the result page, the other one is to make configurable the notes we display.

If we add a syspref to list the subfields we want to display, should it drive the behaviour for the OPAC as well?
Comment 10 Katrin Fischer 2022-11-17 12:33:41 UTC
Maybe more like a denylist? We could mimick NotesToHide used for the 5xx in bibliographic records and the OPAC.