Bug 3018 - Url's contain spaces
Summary: Url's contain spaces
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: rel_3_2
Hardware: PC All
: PATCH-Sent (DO NOT USE) normal
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
: 4347 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-09 04:16 UTC by Chris Cormack
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed fix (58.52 KB, patch)
2010-05-28 14:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Proposed fix for 3.0.x (49.45 KB, patch)
2010-08-10 14:11 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:05:26 UTC


---- Reported by robert.heath@vauntie.com 2009-03-09 04:16:42 ----

when entering a new catalog item, if the '...' is clicked beside the '000 - leader' and attempt is made to open a url such as 'http://intranet_marc_zebra.koha-fr.org/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_leader.pl&index=tag_000_subfield_00_958076_513636&result=     nam a22     7a 4500' 

In windows, the spaces at the end of the url break ie6 and 7 and a window will not open. In firefox the URL is truncated at the = . Urls should not contain spaces.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:05 UTC  ---

This bug was previously known as _bug_ 3018 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3018

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was robert.heath@vauntie.com.

Comment 1 Owen Leonard 2010-05-28 14:49:09 UTC
Created attachment 2186 [details] [review]
Proposed fix

My investigation finds that the problem in Internet Explorer was not with the spaces in the URL but with the spaces in the "name" attribute of the pop-up window. Converting spaces to underscores allows the plugin links to work correctly.
Comment 2 Galen Charlton 2010-06-04 01:00:03 UTC
Push fix (note that patch had typo in bug number).  Please test and close.
Comment 3 Owen Leonard 2010-08-10 14:11:22 UTC
Created attachment 2495 [details] [review]
Proposed fix for 3.0.x
Comment 4 Owen Leonard 2010-08-27 19:13:40 UTC
*** Bug 4347 has been marked as a duplicate of this bug. ***