Bug 30239 - Only items that are allowed to be reserved should be considered when checking if an item can be reserved
Summary: Only items that are allowed to be reserved should be considered when checking...
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-07 00:30 UTC by Aleisha Amohia
Modified: 2022-12-12 21:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2022-03-07 00:30:48 UTC
The 'on shelf holds' circulation rule defines whether all or some items must be unavailable for a hold to be placed. If 'on shelf holds' is set so all items must be unavailable to place holds, then only items that allow reserves should be considered in that.

For example:
You have a record with a bunch of different itemtypes attached: Biblio A has three items - a book, a DVD, and a magazine. 

Books and DVDs have circulation rules where reserves are allowed (reserves allowed > 0).
Magazines have a circulation rule where reserves are NOT allowed (reserves allowed == 0);
'On shelf holds' is set to 'all items must be unavailable'.

The book and DVD for Biblio A are both checked out and the magazine is not. This means that all items that COULD be reserved are unavailable so a patron should be able to place a hold on them. However, because the magazine is not checked out, Koha things there is an item still available and blocks the patron from placing a hold, even though magazines are not allowed to be reserved.

When checking if an item can be reserved based on the 'on shelf holds' rule, we should only consider items that allow reserves in the first place.
Comment 1 Aleisha Amohia 2022-03-07 02:29:05 UTC
Never mind - I can see this works as expected in upstream! Just need to backport a fix for our library :)
Comment 2 Katrin Fischer 2022-03-07 06:36:32 UTC
You scared me there for a moment! Can you share which version it#s broken in?
Comment 3 Aleisha Amohia 2022-03-07 20:24:15 UTC
I think it was more a case of circ rules and sysprefs not being set how we needed them!
Comment 4 Katrin Fischer 2022-03-07 20:36:49 UTC
Thx Aleisha!