Bug 30349 - Cleanup bulkmarcimport.pl
Summary: Cleanup bulkmarcimport.pl
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: davewood
QA Contact: Testopia
URL:
Keywords: release-notes-needed
Depends on: 25539
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-24 11:09 UTC by davewood
Modified: 2024-01-12 10:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch 0001 fix indentation (2.85 KB, patch)
2022-03-24 11:36 UTC, davewood
Details | Diff | Splinter Review
use double dashes (5.68 KB, patch)
2022-03-24 11:37 UTC, davewood
Details | Diff | Splinter Review
more double dashes (1.35 KB, patch)
2022-03-24 12:02 UTC, davewood
Details | Diff | Splinter Review
Bug 30349: Tidy bulkmarcimport.pl to fix indentations (42.58 KB, patch)
2024-01-03 16:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30349: Use double dash for multi character option names (5.83 KB, patch)
2024-01-03 16:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30349: More double dashes (1.29 KB, patch)
2024-01-03 16:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30349: Tidy bulkmarcimport.pl to fix indentations (42.65 KB, patch)
2024-01-12 10:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30349: Use double dash for multi character option names (5.90 KB, patch)
2024-01-12 10:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30349: More double dashes (1.36 KB, patch)
2024-01-12 10:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30349: Add missing double dash (--delete) to POD (934 bytes, patch)
2024-01-12 10:07 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description davewood 2022-03-24 11:09:29 UTC
the help page of bulkmarcimport.pl doesnt use double dashes for multi-character options.

Id like to update the help info and add multi-character options where they are missing. (e.g. --help for -h)
Comment 1 davewood 2022-03-24 11:36:05 UTC
Created attachment 132127 [details] [review]
patch 0001 fix indentation
Comment 2 davewood 2022-03-24 11:37:09 UTC
Created attachment 132128 [details] [review]
use double dashes

use double dashes, add some multi char options where only a single char option was available e.g. --help for -h
Comment 3 davewood 2022-03-24 11:37:39 UTC
powered by HKS3 (www.koha-support.eu)
Comment 4 davewood 2022-03-24 12:02:53 UTC
Created attachment 132130 [details] [review]
more double dashes
Comment 5 Katrin Fischer 2022-03-26 20:04:07 UTC
Don't forget to switch to "Needs sign-off" once this is ready for testing!
Comment 6 Lucas Gass 2023-04-14 15:23:54 UTC
A couple failures from the QA script:

 FAIL	misc/migration_tools/bulkmarcimport.pl
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 579)



Processing additional checks

	* Commit title does not start with 'Bug XXXXX: ' - 23a34f0d0b
	* Commit title does not start with 'Bug XXXXX: ' - 6b73fdeb22
	* Commit title does not start with 'Bug XXXXX: ' - 7d5ade6229


Can these be fixed please?
Comment 7 Martin Renvoize 2024-01-03 16:56:20 UTC
Created attachment 160492 [details] [review]
Bug 30349: Tidy bulkmarcimport.pl to fix indentations

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2024-01-03 16:56:22 UTC
Created attachment 160493 [details] [review]
Bug 30349: Use double dash for multi character option names

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2024-01-03 16:56:24 UTC
Created attachment 160494 [details] [review]
Bug 30349: More double dashes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2024-01-03 16:57:48 UTC
Rebased, added proper commit lines and signed off
Comment 11 Jonathan Druart 2024-01-12 10:07:24 UTC
Created attachment 160913 [details] [review]
Bug 30349: Tidy bulkmarcimport.pl to fix indentations

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2024-01-12 10:07:26 UTC
Created attachment 160914 [details] [review]
Bug 30349: Use double dash for multi character option names

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2024-01-12 10:07:29 UTC
Created attachment 160915 [details] [review]
Bug 30349: More double dashes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Jonathan Druart 2024-01-12 10:07:32 UTC
Created attachment 160916 [details] [review]
Bug 30349: Add missing double dash (--delete) to POD

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>