Bug 30401 - Convert budgets administration page tabs to Bootstrap
Summary: Convert budgets administration page tabs to Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 29226
  Show dependency treegraph
 
Reported: 2022-03-29 17:16 UTC by Owen Leonard
Modified: 2022-12-12 21:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30401: Convert budgets administration page tabs to Bootstrap (8.75 KB, patch)
2022-03-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30401: Convert budgets administration page tabs to Bootstrap (8.81 KB, patch)
2022-03-31 21:53 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30401: Convert budgets administration page tabs to Bootstrap (8.86 KB, patch)
2022-04-03 09:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-03-29 17:16:30 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the budgets administration template with Bootstrap.
Comment 1 Owen Leonard 2022-03-29 17:52:40 UTC
Created attachment 132487 [details] [review]
Bug 30401: Convert budgets administration page tabs to Bootstrap

This patch updates the budgets administration page to use Bootstrap tabs
instead of jQueryUI.

This patch contains indentation changes, so ignore whitespace when you
use your preferred diff tool.

To test, apply the patch and go to Administration -> Budgets. Check that
the "Active budgets" and "Inactive budgets" work correctly.

Append "?tab=2" to the page URL to confirm that the second tab is
preselected.
Comment 2 Lucas Gass 2022-03-31 21:53:02 UTC
Created attachment 132809 [details] [review]
Bug 30401: Convert budgets administration page tabs to Bootstrap

This patch updates the budgets administration page to use Bootstrap tabs
instead of jQueryUI.

This patch contains indentation changes, so ignore whitespace when you
use your preferred diff tool.

To test, apply the patch and go to Administration -> Budgets. Check that
the "Active budgets" and "Inactive budgets" work correctly.

Append "?tab=2" to the page URL to confirm that the second tab is
preselected.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2022-04-03 09:32:33 UTC
Created attachment 132908 [details] [review]
Bug 30401: Convert budgets administration page tabs to Bootstrap

This patch updates the budgets administration page to use Bootstrap tabs
instead of jQueryUI.

This patch contains indentation changes, so ignore whitespace when you
use your preferred diff tool.

To test, apply the patch and go to Administration -> Budgets. Check that
the "Active budgets" and "Inactive budgets" work correctly.

Append "?tab=2" to the page URL to confirm that the second tab is
preselected.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Fridolin Somers 2022-04-12 09:42:07 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄