It would be useful, especially with Bug 29015, for shelving location to be its own column in the Holds Queue. This would allow for more flexibility in how libraries view and sort their queues, especially if it's configurable in Table settings.
Created attachment 132659 [details] [review] Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid.
patch does not apply
*** Bug 33889 has been marked as a duplicate of this bug. ***
Created attachment 168217 [details] [review] Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid.
In my test the wrong column is getting hidden. It looks like the "columnname: location" in columns_settings.yml is out of sequence?
Created attachment 168235 [details] [review] Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid.
(In reply to Owen Leonard from comment #5) > In my test the wrong column is getting hidden. It looks like the > "columnname: location" in columns_settings.yml is out of sequence? Oops, thanks for testing. Revised and reset to NSO.
Created attachment 168238 [details] [review] Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 168244 [details] [review] Bug 30411: Put shelving location into its own column in holds queue To test: 1. Put some items on hold, make some bib level holds and some item level holds. Make sure that some of the holds have different shelving locations. 2. Build the holds queue. In KTD: perl /kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl 3. Notice that the shelving location is in the same column as itemcallnumber 4. Apply patch and restart_all 5. Reload the holds queue and notice that shelving location now has it's own column. 6. Make sure you can sort by shelving location correctly. 7. Re-run the holds queue and apply the filter for shelving location. Make sure all your holds of that shelving location are shown. 8. While in the holds queue try usiong the 'Shelving location' filter on the left side of the page, make sure it works right. 9. Go to Admin > Table settings. Try hiding the shelving location column and reload the holds queue to make sure it is properly hidden. 10. Try hiding some other columns via Table settings to make sure all columns are still properly being hid. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me.
Pushed for 24.11! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #10) > Hm sequence... I don't think we have a real standard there. I would have > probably put the location after the Home library, instead of having the > collection between, but not a blocker for me. I'm happy to file a follow-up if you would like to follow a more standard sequence.
I think orienting ourselves at the items/holdings table might be an idea. Maybe if we can get one more vote for this to be one way or the other :) (and just heading out for the day too)