When setting a rules for a specific branch the default rule is displayed incorrectly To test: 1 - Browse to 'Administration->Circulation and fines rules' 2 - Make sure you are editing 'Standard rules for all libraries' 3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine' 4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)' 5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine' 6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)'
Created attachment 133028 [details] [review] Bug 30471: Correct display of default rules To test: 1 - Browse to 'Administration->Circulation and fines rules' 2 - Make sure you are editing 'Standard rules for all libraries' 3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine' 4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)' 5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine' 6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)' 7 - Apply patch and repeat, note the default descriptions now display correctly
This appears to happen when the 'Standard' rule is 'Refund lost item charge and charge new overdue fine' (displayed for branches as 'Use default (Refund lost item charge and restore overdue fine)') or 'Refund lost item charge and restore overdue fine' (displayed for branches as 'Use default 'Refund lost item charge and charge new overdue fine)'. Branches display correctly when the 'Standard' is 'Leave lost item charge' or 'Refund lost item charge'.
Bug still valid - but patch no longer applies.
Created attachment 137958 [details] [review] Bug 30471: Correct display of default rules To test: 1 - Browse to 'Administration->Circulation and fines rules' 2 - Make sure you are editing 'Standard rules for all libraries' 3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine' 4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)' 5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine' 6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)' 7 - Apply patch and repeat, note the default descriptions now display correctly
Created attachment 137959 [details] [review] Bug 30471: Correct display of default rules To test: 1 - Browse to 'Administration->Circulation and fines rules' 2 - Make sure you are editing 'Standard rules for all libraries' 3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine' 4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)' 5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine' 6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)' 7 - Apply patch and repeat, note the default descriptions now display correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Great, thanks Nick - works as described, signing off.
Created attachment 137986 [details] [review] Bug 30471: Correct display of default rules To test: 1 - Browse to 'Administration->Circulation and fines rules' 2 - Make sure you are editing 'Standard rules for all libraries' 3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and charge new overdue fine' 4 - Swtich to edit rules for a specific library, click on the dropdown for 'Lost item fee refund on return policy' and note default says 'Use default (Refund lost item charge and restore overdue fine)' 5 - Switch default/all libraries rule to 'Refund lost item charge and restore overdue fine' 6 - On specific branch note the default option is now 'Use default (Refund lost item charge and charge new overdue fine)' 7 - Apply patch and repeat, note the default descriptions now display correctly Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
Thanks! Pushed to 21.11 for 21.11.12
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.