Items batch modification is broken looks like it is since Bug 29957 I get the error : Can't call method "value" on an undefined value at /kohadevbox/koha/tools/batchMod.pl line 87 86: my %cookies = parse CGI::Cookie($cookie); 87: my $sessionID = $cookies{'CGISESSID'}->value;
We see 2 ways : > git grep 'CGI::Cookie->fetch' admin/import_export_authtype.pl:my %cookies = CGI::Cookie->fetch(); admin/import_export_framework.pl:my %cookies = CGI::Cookie->fetch(); authorities/merge_ajax.pl:my %cookies = CGI::Cookie->fetch; cataloguing/merge_ajax.pl:my %cookies = CGI::Cookie->fetch; opac/opac-ratings-ajax.pl: my %cookies = CGI::Cookie->fetch; opac/opac-tags.pl: my %cookies = CGI::Cookie->fetch; tags/review.pl: my %cookies = CGI::Cookie->fetch; tools/background-job-progress.pl:my %cookies = CGI::Cookie->fetch; tools/upload-file.pl:my %cookies = CGI::Cookie->fetch; 16:05:46 ~/git/koha-master [ master | v21.11.00 p+1076 | u= ] > git grep 'parse CGI::Cookie' offline_circ/enqueue_koc.pl:my %cookies = parse CGI::Cookie($cookie); offline_circ/process_koc.pl:my %cookies = parse CGI::Cookie($cookie); tools/batchMod.pl:my %cookies = parse CGI::Cookie($cookie); tools/manage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie); tools/modborrowers.pl:my %cookies = parse CGI::Cookie($cookie); tools/stage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie); tools/upload-cover-image.pl:my %cookies = parse CGI::Cookie($cookie);
Created attachment 133273 [details] [review] Bug 30525: Items batch modification broken This patch modifies instances in the code which try to get cookies using: my %cookies = parse CGI::Cookie($cookie); In some cases the relevant lines can be removed because they are unused. In others it can be replaced with: my %cookies = CGI::Cookie->fetch(); To test, apply the patch and restart_all. Test the following pages to confirm they load without errors: - Circulation -> Offline circulation file upload - Circulation -> Offline circulation -> Add to queue - Tools -> Batch item modification - Tools -> Stage MARC for import - Tools -> Staged MARC management - Tools -> Batch patron modification - Tools -> Upload local cover image
Created attachment 133411 [details] [review] Bug 30525: Items batch modification broken This patch modifies instances in the code which try to get cookies using: my %cookies = parse CGI::Cookie($cookie); In some cases the relevant lines can be removed because they are unused. In others it can be replaced with: my %cookies = CGI::Cookie->fetch(); To test, apply the patch and restart_all. Test the following pages to confirm they load without errors: - Circulation -> Offline circulation file upload - Circulation -> Offline circulation -> Add to queue - Tools -> Batch item modification - Tools -> Stage MARC for import - Tools -> Staged MARC management - Tools -> Batch patron modification - Tools -> Upload local cover image Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 133594 [details] [review] Bug 30525: Items batch modification broken This patch modifies instances in the code which try to get cookies using: my %cookies = parse CGI::Cookie($cookie); In some cases the relevant lines can be removed because they are unused. In others it can be replaced with: my %cookies = CGI::Cookie->fetch(); To test, apply the patch and restart_all. Test the following pages to confirm they load without errors: - Circulation -> Offline circulation file upload - Circulation -> Offline circulation -> Add to queue - Tools -> Batch item modification - Tools -> Stage MARC for import - Tools -> Staged MARC management - Tools -> Batch patron modification - Tools -> Upload local cover image Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05
Missing dependency, not backported to 21.05