The column was removed on bug 14570 (19.11) but the API mapping was inadvertedly kept. We should remove it. To test: - Try to filter a request by that attribute: http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?guarantor_id=1 http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?q={"guarantor_id"=1} => FAIL: You get a 500
Created attachment 133282 [details] [review] Bug 30534: Remove guarantor_id attribute from the patron object This patch removes an attribute that was actually removed 3 years ago and causes an exception when trying to search for it. The API responses don't include it anyways. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 133398 [details] [review] Bug 30534: Remove guarantor_id attribute from the patron object This patch removes an attribute that was actually removed 3 years ago and causes an exception when trying to search for it. The API responses don't include it anyways. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 133530 [details] [review] Bug 30534: Remove guarantor_id attribute from the patron object This patch removes an attribute that was actually removed 3 years ago and causes an exception when trying to search for it. The API responses don't include it anyways. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
There are more occurrences that haven't been removed, see bug 14570 comment 251
The bug description makes it sound a bit like the column should be in the database, but I think this is about removing some left-over code, right?
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
*** Bug 27077 has been marked as a duplicate of this bug. ***
Pushed to 21.11.x for 21.11.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.