Bug 30543 - Decouple DumpSearchQueryTemplate from other template dump preferences
Summary: Decouple DumpSearchQueryTemplate from other template dump preferences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 24103
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-14 13:18 UTC by Nick Clemens (kidclamp)
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences (3.03 KB, patch)
2022-04-14 13:20 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences (3.09 KB, patch)
2022-08-01 17:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences (3.14 KB, patch)
2022-08-08 19:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-04-14 13:18:24 UTC
When using dump search query to debug search issues it would be simpler if we could get only the search query
Comment 1 Nick Clemens (kidclamp) 2022-04-14 13:20:19 UTC
Created attachment 133310 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense
Comment 2 ByWater Sandboxes 2022-08-01 17:57:31 UTC
Created attachment 138485 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Katrin Fischer 2022-08-08 19:40:37 UTC
Created attachment 138853 [details] [review]
Bug 30543: Decouple DumpSearchQueryTemplate from other tempalte dump preferences

To test:
1 - Enable DumpSearchQueryTemplate
2 - Confirm you can find the search query in the HTML as a comment
3 - Enable other template dump preference
4 - Confirm they work as before
5 - Confirm new description of preference makes sense

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-08-09 11:46:38 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass (lukeg) 2022-09-30 22:38:58 UTC
Enhancement will not be backported to 22.05.x series unless requested