Once the search is done with this plugin some of the authorities are wrong displayed because parts and links are missing. It is not the case if the search is made via authority mobile
Created attachment 133359 [details] [review] Bug 30554: Wrong display of authorities records in the Authority search plugin With this patch the display of the authorities records is available at XSLT format Test plan: 1)Make sure to have at least one Authority Type defined 2)Home > Cataloging > New record > tab.7 Field 700$a 3)Click on the Tag editor button 4)Click on Search button and notice the displaying of the results 5)Apply patch and repeat 3) and 4) 6)The results are now displayed at XSLT format
Doesn't apply: Applying: MT 36361: Wrong display of authorities records in the Authority search plugin error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt). error: could not build fake ancestor Patch failed at 0001 MT 36361: Wrong display of authorities records in the Authority search plugin
Created attachment 156824 [details] Very simple XSLT for testing purposes (works with MARC21 and UNIMARC)
Created attachment 156825 [details] [review] Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin Test plan: 1. Set AuthorityXSLTResultsDisplay to a valid XSL file (see bug 30554 attachments, there is an example XSL file) 2. Go to the bibliographic record editor (edit an existing one or create a new one) 3. Find a field linked to authorities and open the plugin 4. Start a search and verify that the results are displayed using the XSLT output (if using the example file it should be a link saying "Authority #<authid>")
Created attachment 156826 [details] [review] Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin Test plan: 1. Set AuthorityXSLTResultsDisplay to a valid XSL file (see bug 30554 attachments, there is an example XSL file) 2. Go to the bibliographic record editor (edit an existing one or create a new one) 3. Find a field linked to authorities and open the plugin 4. Start a search and verify that the results are displayed using the XSLT output (if using the example file it should be a link saying "Authority #<authid>") Sponsored-by: Écoles nationales supérieure d'architecture (ENSA)
Created attachment 157293 [details] [review] Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin Test plan: 1. Set AuthorityXSLTResultsDisplay to a valid XSL file (see bug 30554 attachments, there is an example XSL file) 2. Go to the bibliographic record editor (edit an existing one or create a new one) 3. Find a field linked to authorities and open the plugin 4. Start a search and verify that the results are displayed using the XSLT output (if using the example file it should be a link saying "Authority #<authid>") Sponsored-by: Écoles nationales supérieure d'architecture (ENSA) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 157294 [details] Screenshots - before and after patch applied Testing notes (using KTD): 1. Edit any record (for example, CGI programming with Perl). 2. Add another topical term in 650$a (repeat the tag, click on the tag editor, click search). 3. Default search results format is displayed (see attachment). 4. Apply the patch and restart_all. 5. Save the simple record attached to the bug to somewhere like /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/AuthorityXSLTResultsDisplay.xsl 6. Update the AuthorityXSLTResultsDisplay system preference with this path. 7. Repeat steps 1-2. 8. Note that the search results are displayed using the custom XSLT file (see attachment). Note: Only tested on a MARC21 instance.
Comment on attachment 157294 [details] Screenshots - before and after patch applied File was not complete - will repost
Created attachment 157295 [details] Screenshots - before and after patch applied Screenshot of search results - before and after the patch is applied.
Created attachment 161517 [details] [review] Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin Test plan: 1. Set AuthorityXSLTResultsDisplay to a valid XSL file (see bug 30554 attachments, there is an example XSL file) 2. Go to the bibliographic record editor (edit an existing one or create a new one) 3. Find a field linked to authorities and open the plugin 4. Start a search and verify that the results are displayed using the XSLT output (if using the example file it should be a link saying "Authority #<authid>") Sponsored-by: Écoles nationales supérieure d'architecture (ENSA) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161518 [details] [review] Bug 30554: Embelished MARC21 XSLT example Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
There are no regressions caused by this, though I'd love to have a much more comprehensive example XSLT that at least mimicked the existing non-xslt display. I've started that task, but my MARC21 isn't entirely up to the task and I'd appreciate some help getting that done. However.. I do think we can Pass QA as is to get the foundations of the feature in.. at a future point I'd like to remove the non-xslt view and just replace it with this as we have done for biblio displays.
Created attachment 161545 [details] [review] Bug 30554: Embelished MARC21 XSLT example Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
*** Bug 32512 has been marked as a duplicate of this bug. ***
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12