30566 – Incorporate link handling in OPAC's biblio-title include

Bug 30566 - Incorporate link handling in OPAC's biblio-title include

Summary: Incorporate link handling in OPAC's biblio-title include

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	OPAC (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Owen Leonard
QA Contact:	Testopia

URL:
Keywords:

Depends on:	11529 29609
Blocks:
	Show dependency tree / graph

Reported:	2022-04-19 15:26 UTC by Owen Leonard
Modified:	2023-06-08 22:26 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	Output of titles in the OPAC was centralized into an include file (biblio-title), but unlike the staff interface this didn't include the option of adding a link to the default bibliographic view. This enhancement provides that option. It also updates OPAC pages where the biblio-title include was previously wrapped in an anchor tag, to add a link parameter: [% INCLUDE 'biblio-title.inc' link=> 1 %]
Version(s) released in:	22.11.00, 22.05.04
Circulation function:

Attachments
Bug 30566: Incorporate link handling in OPAC's biblio-title include (13.97 KB, patch) 2022-04-19 15:58 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 30566: Incorporate link handling in OPAC's biblio-title include (13.96 KB, patch) 2022-06-06 18:39 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 30566: Incorporate link handling in OPAC's biblio-title include (14.00 KB, patch) 2022-06-06 21:41 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 30566: Incorporate link handling in OPAC's biblio-title include (14.09 KB, patch) 2022-06-16 14:13 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2022-04-19 15:26:16 UTC

Output of titles in the OPAC has been centralized into an include file, but unlike the staff interface this include file doesn't include the option of adding a link using the default bibliographic view.

Comment 1 Owen Leonard 2022-04-19 15:58:01 UTC Comment hidden (obsolete)

Created attachment 133405 [details] [review]
Bug 30566: Incorporate link handling in OPAC's biblio-title include

This patch modifies the biblio-title include so that it can be used to
link to the bibliographic record using the default biblio view.

On pages where the biblio-title include was wrapped in an anchor tag, a
link parameter is added: [% INCLUDE 'biblio-title.inc' link=> 1 %]

To test, apply the patch and view the following pages in the OPAC to
confirm that titles are displayed correctly and that the link to the
bibliographic record is correct:

- Log in to the OPAC: On the "your summary" page, check checkouts,
  overdues, holds, and article requests.
- Check the "your holds history" page.
- Locate a bibliographic record and click "Save to your lists."
  In the popup, the title should be displayed correctly without a link.
- Place a hold, and check the hold confirmation page.
- Check the "Recent comments" page.
- Locate a record which has a local cover image attached, and view the
  image.

Comment 2 David Nind 2022-05-15 23:20:42 UTC

Patch no lomger applies 8-(..

git bz apply 30566

Bug 30566 - Incorporate link handling in OPAC's biblio-title include

133405 - Bug 30566: Incorporate link handling in OPAC's biblio-title include

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 30566: Incorporate link handling in OPAC's biblio-title include
Using index info to reconstruct a base tree...
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 30566: Incorporate link handling in OPAC's biblio-title include

Comment 3 Owen Leonard 2022-06-06 18:39:27 UTC

Created attachment 135733 [details] [review]
Bug 30566: Incorporate link handling in OPAC's biblio-title include

This patch modifies the biblio-title include so that it can be used to
link to the bibliographic record using the default biblio view.

On pages where the biblio-title include was wrapped in an anchor tag, a
link parameter is added: [% INCLUDE 'biblio-title.inc' link=> 1 %]

To test, apply the patch and view the following pages in the OPAC to
confirm that titles are displayed correctly and that the link to the
bibliographic record is correct:

- Log in to the OPAC: On the "your summary" page, check checkouts,
  overdues, holds, and article requests.
- Check the "your holds history" page.
- Locate a bibliographic record and click "Save to your lists."
  In the popup, the title should be displayed correctly without a link.
- Place a hold, and check the hold confirmation page.
- Check the "Recent comments" page.
- Locate a record which has a local cover image attached, and view the
  image.

Comment 4 David Nind 2022-06-06 21:41:48 UTC

Created attachment 135738 [details] [review]
Bug 30566: Incorporate link handling in OPAC's biblio-title include

This patch modifies the biblio-title include so that it can be used to
link to the bibliographic record using the default biblio view.

On pages where the biblio-title include was wrapped in an anchor tag, a
link parameter is added: [% INCLUDE 'biblio-title.inc' link=> 1 %]

To test, apply the patch and view the following pages in the OPAC to
confirm that titles are displayed correctly and that the link to the
bibliographic record is correct:

- Log in to the OPAC: On the "your summary" page, check checkouts,
  overdues, holds, and article requests.
- Check the "your holds history" page.
- Locate a bibliographic record and click "Save to your lists."
  In the popup, the title should be displayed correctly without a link.
- Place a hold, and check the hold confirmation page.
- Check the "Recent comments" page.
- Locate a record which has a local cover image attached, and view the
  image.

Signed-off-by: David Nind <david@davidnind.com>

Comment 5 Jonathan Druart 2022-06-16 14:13:27 UTC

Created attachment 136170 [details] [review]
Bug 30566: Incorporate link handling in OPAC's biblio-title include

This patch modifies the biblio-title include so that it can be used to
link to the bibliographic record using the default biblio view.

On pages where the biblio-title include was wrapped in an anchor tag, a
link parameter is added: [% INCLUDE 'biblio-title.inc' link=> 1 %]

To test, apply the patch and view the following pages in the OPAC to
confirm that titles are displayed correctly and that the link to the
bibliographic record is correct:

- Log in to the OPAC: On the "your summary" page, check checkouts,
  overdues, holds, and article requests.
- Check the "your holds history" page.
- Locate a bibliographic record and click "Save to your lists."
  In the popup, the title should be displayed correctly without a link.
- Place a hold, and check the hold confirmation page.
- Check the "Recent comments" page.
- Locate a record which has a local cover image attached, and view the
  image.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 6 Tomás Cohen Arazi (tcohen) 2022-07-05 12:59:18 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 7 Lucas Gass (lukeg) 2022-08-09 22:27:15 UTC

Backported to 22.05.x for 22.05.04

Comment 8 Arthur Suzuki 2022-08-12 07:58:50 UTC

depends on 29609, which is not present in 21.11.x. won't backport to 21.11