Bug 30571 - Table z3950servers: which fields should be NOT NULL ?
Summary: Table z3950servers: which fields should be NOT NULL ?
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30486
  Show dependency treegraph
 
Reported: 2022-04-20 13:34 UTC by Marcel de Rooy
Modified: 2022-04-20 13:39 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-04-20 13:34:47 UTC
`host` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'target''s host name',
  `port` int(11) DEFAULT NULL COMMENT 'port number used to connect to target',
  `db` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'target''s database name',
  `syntax` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'marc format provided by this target',
  `encoding` mediumtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'characters encoding provided by this target',

Seems to me that those fields should be NOT NULL.
Comment 1 Marcel de Rooy 2022-04-20 13:37:35 UTC
Noting that my production table looks like:

  `host` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,
  `port` int(11) DEFAULT NULL,
  `db` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `syntax` varchar(80) COLLATE utf8mb4_unicode_ci NOT NULL,
  `encoding` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL,

Cannot find out why my host, syntax and encoding are NOT NULL. But it looks like that it is more correct.
Did not find wrong dbrevs.
Comment 2 Marcel de Rooy 2022-04-20 13:39:08 UTC
Linking it to the sync omnibus since it is at least very related in nature.