Bug 30581 - Items should show on the Holds Queue and Holds to Pull even if they have requested transfers
Summary: Items should show on the Holds Queue and Holds to Pull even if they have requ...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal with 15 votes (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 23092
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-21 13:25 UTC by Andrew Fuerste-Henry
Modified: 2024-05-02 16:38 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 30581: Allow requested but not sent items to appear in holds to pull (1.00 KB, patch)
2024-05-02 11:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30581: Exclude unsent transfers from HoldsQueue (1.05 KB, patch)
2024-05-02 11:56 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-04-21 13:25:37 UTC
In bug 23092 Koha added the idea of a transfer that has been requested but not yet sent. The Holds Queue and and Holds to Pull will not show titles/items that have transfers that are not either complete or cancelled, so staff are not alerted to holds on Available items if those items have requested transfers on them. But if the item is checked in, it will trigger the hold.

We should show items in the Holds Queue and Holds to Pull if they have transfers that are requested but not sent.
Comment 1 Rebecca Coert 2022-09-27 16:09:13 UTC
Staff should be alerted to holds on these items, so I agree with Andrew that they should show items in the Holds Queue and Holds to Pull if they have transfers that are requested but not sent.
Comment 2 Michael Adamyk 2023-02-01 15:00:55 UTC
Agreed... this causes a lot of problems since the item in question is really in limbo, similar to an orphaned hold.
Comment 3 Martin Renvoize 2023-05-25 08:59:09 UTC
I 'think' this is a duplicate of bug 33761.. any chance someone could test with that and confirm my suspicions?
Comment 4 Andrew Fuerste-Henry 2023-05-25 15:17:29 UTC
(In reply to Martin Renvoize from comment #3)
> I 'think' this is a duplicate of bug 33761.. any chance someone could test
> with that and confirm my suspicions?

I can confirm that this issue still exists in master after bug 33761. To recreate:
1 - have a bib with an available item
2 - place a hold on that bib
3 - confirm your item shows up on the holds queue
4 - use the Transfers interface to send the item to another branch (you'll be asked to confirm that you want to send it even though there's a hold)
5 - log into the SQL server and delete datesent from your transfer to kick it back to Pending (in the real world, an item would end up in this state due to stock rotation)
6 - confirm that the holdings table on your bib shows the item has a pending transfer
7 - confirm the title isn't on the holds queue anymore (run build_holds_queue if not using the realtime queue)
8 - check the item in and confirm that it does trigger the hold
Comment 5 stacey kingsbury 2023-09-21 18:24:23 UTC
We use the stock rotation feature, and books that are in transit pending status will not show up on the Holds report. This is an issue as our branches can have delays in pulling books for stock rotation.
Comment 6 Martin Renvoize 2024-05-02 11:41:28 UTC
(In reply to stacey kingsbury from comment #5)
> We use the stock rotation feature, and books that are in transit pending
> status will not show up on the Holds report. This is an issue as our
> branches can have delays in pulling books for stock rotation.

The 'Transfers to send' report was actually designed specifically for the stock rotation use case
Comment 7 Martin Renvoize 2024-05-02 11:56:41 UTC
Created attachment 166064 [details] [review]
Bug 30581: Allow requested but not sent items to appear in holds to pull

This patch adds datesent to the exclusions in holds to pull report.
Comment 8 Martin Renvoize 2024-05-02 11:56:44 UTC
Created attachment 166065 [details] [review]
Bug 30581: Exclude unsent transfers from HoldsQueue

This adds an exclusion to remove requested but not yet sent transfers
from the filter when using the Holds Queue
Comment 9 Martin Renvoize 2024-05-02 11:57:27 UTC
Need testing and feedback here before I write the unit tests for it for QA.
Comment 10 Andrew Fuerste-Henry 2024-05-02 16:38:51 UTC
Bug 36762 is making this harder to test in that it's making it harder to transfer an item with a pending hold. I think one should still be able to test this by generating transfers-to-send with the stock rotation tool. I'll just have to remember how stock rotation works.