With es-ES: Template process failed: file error - parse error - holds_table.inc line 216-217: unexpected token (hold) [% " hold.reserve_id="hold.reserve_id" html="html" name="printholdslip" type="button" value="Recibo" |="|"></td> [% ELSE %] at /kohadevbox/koha/C4/Templates.pm line 127
Caused by commit a68021a2387ff1caf854c17fc5331e85926c1f7e Bug 29338: Add print hold/transfer button to request.tt
Created attachment 133569 [details] [review] Bug 30583: Fix hold system for translated templates There are missing quotes, and the translate script is messing up with the generated template. Error is: Template process failed: file error - parse error - holds_table.inc line 216-217: unexpected token (hold) The generated line, without this patch is: 216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%" hold.reserve_id="hold.reserve_id" html="html" name="printholdslip" type="button" value="Recibo" |="|"></td> With this patch applied: 216 <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id | html %]" name="printholdslip" type="button" value="Recibo"></td>
Created attachment 133570 [details] [review] Bug 30583: Fix hold system for translated templates There are missing quotes, and the translate script is messing up with the generated template. Error is: Template process failed: file error - parse error - holds_table.inc line 216-217: unexpected token (hold) The generated line, without this patch is: 216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%" hold.reserve_id="hold.reserve_id" html="html" name="printholdslip" type="button" value="Recibo" |="|"></td> With this patch applied: 216 <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id | html %]" name="printholdslip" type="button" value="Recibo"></td> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks Jonathan, sorry about that one :(
Created attachment 133587 [details] [review] Bug 30583: Fix hold system for translated templates There are missing quotes, and the translate script is messing up with the generated template. Error is: Template process failed: file error - parse error - holds_table.inc line 216-217: unexpected token (hold) The generated line, without this patch is: 216 <td><input %]="%]" class="printholdslip" data-reserve_id="[%" hold.reserve_id="hold.reserve_id" html="html" name="printholdslip" type="button" value="Recibo" |="|"></td> With this patch applied: 216 <td><input class="printholdslip" data-reserve_id="[% hold.reserve_id | html %]" name="printholdslip" type="button" value="Recibo"></td> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05
Pushed to 21.05.x for 21.05.14
Missing dependencies for 20.11.x, it shouldn't be affected, no backport. Bullet dodged :)