These first lines in kohastructure are just ignored by DBIx::RunSQL. They could serve a purpose however when running the file directly on the sql command line. So we should at least add a comment to warn people. On bug 26947 some of these settings are taken over in C4::Installer::load_db_schema.
Created attachment 133876 [details] [review] Bug 30620: Add a warning about /*!VERSION lines in kohastructure Also adding a similar comment in C4::Installer. No test plan, just documentation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: self SO
QA should be trivial too ?
Created attachment 133898 [details] [review] Bug 30620: Add a warning about /*!VERSION lines in kohastructure Also adding a similar comment in C4::Installer. No test plan, just documentation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial improvement, Passing QA. Note however that we will need to consider the .SQL file change as if we start to use koha-dump to generate the structure file regularly (to keep updatedatabase and the kohastrucutre files in sync as intended) it will wipe out the change here.
Not a good idea, kohastructure.sql will be regenerated at the next major release.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
Documentation for developers/administrators.. no wider documentation change is required.