When you look at a biblio's detail you see | Holdings (count) | Descriptions (count) | ... The patron detail page displays things in a way that looks untidy and inconsistent with other areas. | count Checkout(s) | count Hold(s) | ... This is highly opinionated, but I propose we make it consistent with the biblios one.
See also Bug 26979
Created attachment 134650 [details] [review] Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set
There's still some inconsistency on how we display Claims and Clubs. But that could belong to some other bug.
Created attachment 134657 [details] [review] Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134721 [details] [review] Bug 30695: Display tabs more consistently in patron details This patch makes tab texts display 'Thing (count)' as opossed to the current mix we have. To test, check before after the patch how it looks. You need to: - Enable ArticleRequests - Set ClaimReturnedLostValue to 1 (for example) - Have some clubs set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 134722 [details] [review] Bug 30695: (QA follow-up) Catch moremember.tt too This patch does the same treatment for moremember.tt where the same summary block is includes. We also correct the tab order to be a little more consistent too. We should really move this to an include and refer to it from both templates instead of this copy/paste code.. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This is a marked improvement.. I will revisit the see also now to see how they relate. Passing QA on this one though.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
This breaks a Selenium test : kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/selenium/basic_workflow.t t/db_dependent/selenium/basic_workflow.t .. 1/22 CP main = 0.82 t/db_dependent/selenium/basic_workflow.t .. 3/22 CP add patron category = 2.00 t/db_dependent/selenium/basic_workflow.t .. 5/22 CP add patron = 1.66 CP add biblio = 0.08 t/db_dependent/selenium/basic_workflow.t .. 11/22 CP add items = 3.94 t/db_dependent/selenium/basic_workflow.t .. 12/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (1)' # expected: '1 Checkout(s)' t/db_dependent/selenium/basic_workflow.t .. 14/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (2)' # expected: '2 Checkout(s)' t/db_dependent/selenium/basic_workflow.t .. 16/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 238. # got: 'Checkouts (3)' # expected: '3 Checkout(s)'
Created attachment 135053 [details] [review] Bug 30695: (follow-up) Fix selenium test The tab title words were re-ordered and we forgot to update the corresponding selenium test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Fix attached, tested and pushed as rm assist :)
(In reply to Martin Renvoize from comment #11) > Fix attached, tested and pushed as rm assist :) Great thanks ;)