When logs are enabled and an action is performed in the staff interface, it is displayed in the log interface column as "Intranet". This should be displayed as "Staff interface", as per the terminology guidelines: https://wiki.koha-community.org/wiki/Terminology#I To reproduce: 1. Any action logged by the staff interface should show this in the log viewer. 2. Example: . Enable logs for cataloging (enabled by default in koha-testing-docker) (CataloguingLog system preference). . For a record, change the shelving location for any item to something else. . Check the logs (Tools > Additional tools > Log viewer then Submit). . The interface column shows that the change was made in the "Intranet".
Created attachment 167331 [details] [review] Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com>
This only fixes the usage of 'Intranet' as displayed on the log viewer page. It does not fix the addition of entries to the action_log table (these are added as 'intranet' to the interface column). It also doesn't fix the exported file - the CSV file exported still shows 'intranet' as the interface. If these need to be fixed, this will need to be done by someone else who can work out how to do it.
Created attachment 167361 [details] [review] Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks for the sign-off Lucas!
Created attachment 167669 [details] [review] Bug 30715: Terminology for the log viewer - use 'Staff interface' instead of 'Intranet' The log viewer (Tools > Additional tools > Log viewer) uses 'Intranet' as: - an option for filtering what log entries to display. - a value in the log entries interface column, for log entries. Koha's terminology guideline is to use 'Staff interface' instead of 'Interface' (https://wiki.koha-community.org/wiki/Terminology#I). Test plan: 1. Perform some actions that will create log entries when using the staff interface. For example: 1.1 Enable the UseRecalls system preference. 1.2 Edit the title for a record. 1.3 Add an item for a record. 2. Use the log viewer to view the logged changes: 2.1 Go to Tools > Additional tools > Log viewer. 2.2 Select Submit. 2.3 Log entries are displayed for the changes made. 3. Note that: 3.1 For the log viewer 'Interface' filter options, "All" is selected by default, and other options are Intranet, OPAC, SIP, Command-line, REST API, and Cron job. 3.2 For the changes viewed in step 2, the value displayed in the 'Interface' column is 'Intranet'. 4. Apply the patch. 5. Refresh the page. 6. Note that: 5.1 For the interface filter options, 'Intranet' is now changed to 'Staff interface'. 5.2 In the list of log entries, the value in the interface column is now 'Staff interface'. 7. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
String change, looks good and QA script is happy. Passing QA
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.02
Pushed to 23.11.x for 23.11.07
Pushed to 23.05.x for 23.05.15