I am seeing this error in the console in master: Uncaught TypeError: j is undefined Not sure if that is a local issue, could someone try and confirm?
I don't see anything in master.
Very strange, thx Owen.
I see this error as well on current master!
In Firefox I see the exact same error as Cait. In Chrome I see something a bit different: jquery-3.6.0.min_21.1200055.js:2 Uncaught TypeError: Cannot read properties of undefined (reading 'form') at s.fn.init.rules (jquery.validate.min_21.1200055.js:4:1470) at HTMLDocument.<anonymous> (opac-memberentry.pl:1568:67) at e (jquery-3.6.0.min_21.1200055.js:2:30038) at t (jquery-3.6.0.min_21.1200055.js:2:30340)
I was able to see it after emptying the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences and looking at the self-registration view. An upgrade of the validation plugin seems to fix the error, so I suspect the problem is related to Bug 29155, "Upgrade jquery version to 3.6.0." The error doesn't appear to affect the functionality of the page, so I don't think we need to rush a fix.
Created attachment 135541 [details] [review] Bug 30746: Fix JS error on opac-memberentry Empty PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField Go to opac-memberentry.pl Notice the JS error Uncaught TypeError: j is undefined Apply this patch Go to opac-memberentry.pl => no JS error Fill the pref with some values Go to opac-memberentry.pl => Confirm that the fields you marked as mandatory as flagged accordinly on the UI
Created attachment 135549 [details] [review] Bug 30746: Fix JS error on opac-memberentry Empty PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField Go to opac-memberentry.pl Notice the JS error Uncaught TypeError: j is undefined Apply this patch Go to opac-memberentry.pl => no JS error Fill the pref with some values Go to opac-memberentry.pl => Confirm that the fields you marked as mandatory as flagged accordinly on the UI Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 135724 [details] [review] Bug 30746: Fix JS error on opac-memberentry Empty PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField Go to opac-memberentry.pl Notice the JS error Uncaught TypeError: j is undefined Apply this patch Go to opac-memberentry.pl => no JS error Fill the pref with some values Go to opac-memberentry.pl => Confirm that the fields you marked as mandatory as flagged accordinly on the UI Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
thx! pushed to 21.11.x for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.