Created attachment 134980 [details] [review]
Bug 30751: Add notice printing to automatic_renewals.pl

This patch adds notice preview to the automatic_renewals.pl script.

Test plan
1) Setup automtic renewals and add some checkouts with autorenewal
   enabled
2) Run the automatic_renewals.pl script with verbose mode. (without
   confirm if your testing and don't want to actually send notice or
   perform the renewals)
3) Confirm that you no get notices printed at the end of the output

Created attachment 134984 [details] [review]
Bug 30751: Add notice printing to automatic_renewals.pl

This patch adds notice preview to the automatic_renewals.pl script.

Test plan
1) Setup automtic renewals and add some checkouts with autorenewal
   enabled
2) Run the automatic_renewals.pl script with verbose mode. (without
   confirm if your testing and don't want to actually send notice or
   perform the renewals)
3) Confirm that you no get notices printed at the end of the output

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Right now, the error is not set in the issue object if not confirm:
$auto_renew->auto_renew_error($error)->store if $confirm;

I suspect we need:
$auto_renew->auto_renew_error($error)
$auto_renew->store if $confirm;

Additionally:
173         if ($confirm){
174             my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchco    de, undef, undef, undef, 0 );
175             $auto_renew->auto_renew_error(undef)->store;
176         }


Otherwise the messages I get don't have the correct info/status

There may be other instances like this to check as well

Hmm, I think I see what you're saying.. but I don't think the suggested change will work either.  

Notices always fetch the data from the database for themselves, so splitting out the change and store calls won't help as the notice itself will still refer back to the database on generation.

Hmm...

So we really need bug 19966 for this to ever work I think.