This test contains 3 skips on Jenkins. It uses a MARC file. We could quite easily resolve this with TestBuilder.
Created attachment 134998 [details] [review] Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 134999 [details] [review] Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 135000 [details] [review] Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
So we should no longer see these 3 on Jenkins: t_db_dependent_Koha_Authority_t 0.82 sec 0 3 8 11
Created attachment 135004 [details] [review] Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135005 [details] [review] Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135006 [details] [review] Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
I tested in koha-testing-docker: 1. Ran tests before applying patches and these passed: prove t/db_dependent/Koha_Authority.t 2. Ran tests using new name after applying patches, and these passed: prove t/db_dependent/Koha_MetadataRecord_Authority.t Hope that is sufficient.
(In reply to David Nind from comment #8) > I tested in koha-testing-docker: > > 1. Ran tests before applying patches and these passed: prove > t/db_dependent/Koha_Authority.t > > 2. Ran tests using new name after applying patches, and these passed: prove > t/db_dependent/Koha_MetadataRecord_Authority.t > > Hope that is sufficient. Great. Thx
Created attachment 135104 [details] [review] Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 135105 [details] [review] Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 135106 [details] [review] Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> JD amended patch: remove Dumper Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Search.t failing now, the records file was being used there as well t/db_dependent/Search.t: 277 $mock_zebra->load_records( 278 sprintf( "%s/%s/zebraexport/authority", $sourcedir, lc($marcflavour) ), 279 'iso2709', 'authorities', 1 280 );
(In reply to Nick Clemens from comment #14) > Search.t failing now, the records file was being used there as well > > t/db_dependent/Search.t: > 277 $mock_zebra->load_records( > 278 sprintf( "%s/%s/zebraexport/authority", $sourcedir, > lc($marcflavour) ), > 279 'iso2709', 'authorities', 1 > 280 ); Will have a look
Created attachment 135702 [details] [review] Bug 30756: (follow-up) Restore MARC21 authority file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Tomás Cohen Arazi from comment #16) > Created attachment 135702 [details] [review] [review] > Bug 30756: (follow-up) Restore MARC21 authority file > > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Thx. Considering this at least a temporary fix? When I grepped on this exported_records file, I couldnt find a reference, but it is pumped into zebraidx via the folder where it is (without file name). A discussion on itself is how we should test the search engine. We are starting Zebra and Elastic now to do so. Calling it a mock ;)
Pushed to 22.05.x for 22.05.01
thx, pushed to 21.11.x for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.