Bug 30769 - Typo: Item typeX:
Summary: Typo: Item typeX:
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 29660
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-15 13:03 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04


Attachments
Bug 30769: Typo fix in request.tt (1.95 KB, patch)
2022-07-05 17:06 UTC, Michal Urban
Details | Diff | Splinter Review
Bug 30769: Typo fix in request.tt (1.50 KB, patch)
2022-07-05 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30769: Typo fix in request.tt (1.55 KB, patch)
2022-07-06 21:33 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-15 13:03:14 UTC
This appears to be a typo:

koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

Item typeX:
Comment 1 Michal Urban 2022-07-05 17:06:50 UTC
Created attachment 137179 [details] [review]
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed
Comment 2 Owen Leonard 2022-07-05 17:42:50 UTC
Created attachment 137180 [details] [review]
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to
    bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2022-07-06 09:07:52 UTC
Michal, did you write this patch? Why is the author Nick?
Comment 4 Michal Urban 2022-07-06 17:57:14 UTC
(In reply to Jonathan Druart from comment #3)
> Michal, did you write this patch? Why is the author Nick?

I'm not sure, I did write the patch. Maybe I messed something up when doing git bz attach, I sign off on a lot of Nick's patches so it's possible that information from one of his patches was attached to my patch.
Comment 5 Tomás Cohen Arazi 2022-07-06 21:33:35 UTC
Created attachment 137250 [details] [review]
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to
    bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2022-07-06 21:37:25 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-08-12 15:51:48 UTC
Backported to 22.05.x for 22.05.04
Comment 8 Arthur Suzuki 2022-08-16 10:04:36 UTC
Bug not found on 21.11.x. not backporting