Reserves should be holds: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:659 No reserves are allowed on this item
*** Bug 28578 has been marked as a duplicate of this bug. ***
Created attachment 135066 [details] [review] Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term.
For the last change in the patch "Sorry, you are too young to reserve this material.", I think this should read as "Sorry, you are too young to place a hold for this item." instead of "Sorry, you are too young to hold this material."
Created attachment 135438 [details] [review] Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135439 [details] [review] Bug 30772: (follow-up) Age restriction message Improve age restriction message. Signed-off-by: David Nind <david@davidnind.com>
I added a follow-up for the age restriction message - hope I have actually improved the message! For testing, I just reviewed the diff, rather than generating these in the user interfaces.
Created attachment 135450 [details] [review] Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 135451 [details] [review] Bug 30772: (follow-up) Age restriction message Improve age restriction message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Code looks good, qa script happy, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01