Bug 30784 - Rephrase OPACMandatoryHoldDates slightly
Summary: Rephrase OPACMandatoryHoldDates slightly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Danyon Sewell
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-05-17 08:40 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the text for the OPACMandatoryHoldDates system preference. It replaces the URL for the form (opac-reserve) with a description, formats the note similar to other notes, and links to other system preferences mentioned in the description.
Version(s) released in:
22.11.00, 22.05.04


Attachments
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly (1.49 KB, patch)
2022-07-07 23:34 UTC, Danyon Sewell
Details | Diff | Splinter Review
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly (1.54 KB, patch)
2022-07-07 23:48 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly (1.59 KB, patch)
2022-07-08 06:03 UTC, David Nind
Details | Diff | Splinter Review
Bug 30784: (follow-up) Addiional rephrasing (2.19 KB, patch)
2022-07-08 06:03 UTC, David Nind
Details | Diff | Splinter Review
Bug 30784: (follow-up) Additional rephrasing (2.19 KB, patch)
2022-07-08 06:06 UTC, David Nind
Details | Diff | Splinter Review
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly (1.68 KB, patch)
2022-07-08 06:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 30784: (follow-up) Additional rephrasing (2.29 KB, patch)
2022-07-08 06:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-17 08:40:19 UTC
The OPACMandatoryHoldDates system preferen mentions: 

On the opac-reserve form, make...

I think it would be a little nicer to describe the page like we do in other places as not everyone might be used to look at the URL.
Comment 1 Katrin Fischer 2022-05-17 08:42:29 UTC
It might also be nice to add a link to OPACAllowHoldDateInFuture, as this is required in order to set a start date of a hold.
Comment 2 Katrin Fischer 2022-05-17 08:43:01 UTC
(In reply to Katrin Fischer from comment #1)
> It might also be nice to add a link to OPACAllowHoldDateInFuture, as this is
> required in order to set a start date of a hold.

Scratch that, only needs to be linked, it's mentioned already.
Comment 3 Danyon Sewell 2022-07-07 23:34:17 UTC
Created attachment 137349 [details] [review]
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT
Comment 4 Chris Cormack 2022-07-07 23:48:20 UTC
Created attachment 137351 [details] [review]
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Works as expected, needs indpendent sign off
Comment 5 David Nind 2022-07-08 06:03:24 UTC
Created attachment 137358 [details] [review]
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2022-07-08 06:03:31 UTC Comment hidden (obsolete)
Comment 7 David Nind 2022-07-08 06:06:30 UTC
Created attachment 137360 [details] [review]
Bug 30784: (follow-up) Additional rephrasing

Add additional clarifcation, format NOTE: similar to most other
notes in system preferences (bold, start on a new line), and link
to other system preferences mentioned.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2022-07-08 06:07:41 UTC Comment hidden (obsolete)
Comment 9 Marcel de Rooy 2022-07-08 06:18:48 UTC
Created attachment 137363 [details] [review]
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2022-07-08 06:18:52 UTC
Created attachment 137364 [details] [review]
Bug 30784: (follow-up) Additional rephrasing

Add additional clarifcation, format NOTE: similar to most other
notes in system preferences (bold, start on a new line), and link
to other system preferences mentioned.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 11 Marcel de Rooy 2022-07-08 06:19:24 UTC
Welcome Danyon Sewell. Please change Assignee when you submit patches. Thx
Comment 12 Tomás Cohen Arazi 2022-07-08 18:26:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 13 Lucas Gass 2022-08-12 16:36:32 UTC
Backported to 22.05.x for 22.05.04
Comment 14 Arthur Suzuki 2022-08-16 12:39:22 UTC
Can't find this system preference in Koha 21.11.x.
Not backporting, ask if needed.