Bug 3083 - OPAC shows renewal link for items which are on hold or have too many renewals
Summary: OPAC shows renewal link for items which are on hold or have too many renewals
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-01 04:59 UTC by Owen Leonard
Modified: 2016-03-30 13:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix, returning correct value for CanBookBeRenewed() (2.51 KB, patch)
2009-04-01 17:07 UTC, Chris Cormack
Details | Diff | Splinter Review
Amended patch (2.54 KB, patch)
2009-04-01 18:19 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:06:12 UTC


---- Reported by oleonard@myacpl.org 2009-04-01 16:59:19 ----

The user's summary of checkouts shows a "renew" link for all items, whether or not they can be renewed. The renew link should be hidden for items which are on hold for another patron or which have been renewed too many times.



---- Additional Comments From oleonard@myacpl.org 2009-04-01 17:07:27 ----

Created an attachment
Proposed fix, returning correct value for CanBookBeRenewed()

This patch corrects the output of CanBookBeRenewed() (thanks for the assistance Galen) and provides explanations to the user for items which cannot be renewed because of holds or too many renewals.



---- Additional Comments From oleonard@myacpl.org 2009-04-01 18:19:11 ----

Created an attachment
Amended patch

Correction to prevent warnings (more thanks, Galen)



---- Additional Comments From gmcharlt@gmail.com 2009-04-03 23:36:47 ----

Patch pushed to HEAD.  Please test and close.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:06 UTC  ---

This bug was previously known as _bug_ 3083 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3083
Imported an attachment (id=1079)
Imported an attachment (id=1080)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1079 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1080 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.