On the staff main page pending suggestions show some like: Suggestions pending approval: Centerville: 2 / All libraries: 100 It would be nice if we could do the same thing with pending patron modifications Patrons requesting modifications: Centerville: 2 / All libraries: 100
Created attachment 135823 [details] [review] Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct.
Created attachment 137644 [details] [review] Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described, great idea for a feature. I noticed this creates two links that both lead to the same location. At first glance it looks like the first link will only take you to patrons of that library who require approval. Maybe if it was all one link it would be clearer that the destination is the same.
1) I am not sure if we don't give off the wrong impression here. The link for "my library" and "all libraries" is the same, because the patron modification page doesn't filter. But I think having 2 links would give off the impression that they behave differently. Would it be possible to create a link that filters? Or maybe we keep the link on the Patrons requesting... and not on the numbers. 2) We don't take IndependentBranchesPatronModifications into account. I believe if that is 'on' we should only show the library count and could hide the all libraries one. 3) When there are no modification requests for the current library, it reads: Patrons requesting modifications: Centerville: / All libraries: 1 For suggestions we show 0 here, which is a little nicer.