When using the batch patrons modification tool with an existing patron number we still get "No patron card numbers or borrowernumbers given." warning. To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the inspector tool see that cardnumberlist or borrowernumberlist is empty with no data.
Incompleteness came from these changes I suppose: commit:0f7949de Bug 30475: Convert tools pages tabs to Bootstrap (part 2) so yes, please finalize those changes.
Created attachment 135682 [details] [review] Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form.
Created attachment 135694 [details] [review] Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 135726 [details] [review] Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Good catch, Slava!
Glad to hear it, Katrin. Thanks!
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
thx, pushed to 21.11.x for 21.11.07
It looks like missing dependencies for 21.05.x, it doesn't seem affected, no backport. Nothing to document, marking resolved.
This one was actually reverted on 21.11.10, I didn't reproduced the bug.