Bug 30884 - Incomplete replace of jQuery UI tabs in batch patron modification breaks the form sending
Summary: Incomplete replace of jQuery UI tabs in batch patron modification breaks the ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Slava Shishkin
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30475
Blocks: 29226
  Show dependency treegraph
 
Reported: 2022-06-02 08:11 UTC by Slava Shishkin
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01


Attachments
Bug 30884: Fix jQuery selector to correctly detect active tab (1.74 KB, patch)
2022-06-03 16:14 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 30884: Fix jQuery selector to correctly detect active tab (1.80 KB, patch)
2022-06-03 21:32 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30884: Fix jQuery selector to correctly detect active tab (1.85 KB, patch)
2022-06-06 11:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Slava Shishkin 2022-06-02 08:11:00 UTC
When using the batch patrons modification tool with an existing patron number we still get "No patron card numbers or borrowernumbers given." warning.

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the inspector tool see that cardnumberlist or borrowernumberlist is empty with no data.
Comment 1 Andrii Nugged 2022-06-02 11:32:10 UTC
Incompleteness came from these changes I suppose:

commit:0f7949de
Bug 30475: Convert tools pages tabs to Bootstrap (part 2)

so yes, please finalize those changes.
Comment 2 Slava Shishkin 2022-06-03 16:14:32 UTC
Created attachment 135682 [details] [review]
Bug 30884: Fix jQuery selector to correctly detect active tab

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist
   is sent with empty data.

Apply the patch, and then:
1. Fill form Card number or Borrowernumber list and click Continue.
2. Get the result: table with patrons for editing or warning about not found number.
3. Using the inspector tool see that request has data from the active tab in the form.
Comment 3 Lucas Gass 2022-06-03 21:32:16 UTC
Created attachment 135694 [details] [review]
Bug 30884: Fix jQuery selector to correctly detect active tab

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist
   is sent with empty data.

Apply the patch, and then:
1. Fill form Card number or Borrowernumber list and click Continue.
2. Get the result: table with patrons for editing or warning about not found number.
3. Using the inspector tool see that request has data from the active tab in the form.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2022-06-06 11:56:34 UTC
Created attachment 135726 [details] [review]
Bug 30884: Fix jQuery selector to correctly detect active tab

To reproduce:
1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue.
2. It should give "No patron card numbers or borrowernumbers given." warning.
3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist
   is sent with empty data.

Apply the patch, and then:
1. Fill form Card number or Borrowernumber list and click Continue.
2. Get the result: table with patrons for editing or warning about not found number.
3. Using the inspector tool see that request has data from the active tab in the form.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-06-06 11:56:58 UTC
Good catch, Slava!
Comment 6 Slava Shishkin 2022-06-06 13:03:13 UTC
Glad to hear it, Katrin. 
Thanks!
Comment 7 Tomás Cohen Arazi 2022-06-06 14:38:25 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass 2022-06-15 16:22:03 UTC
Pushed to 22.05.x for 22.05.01
Comment 9 Arthur Suzuki 2022-06-21 13:52:18 UTC
thx, pushed to 21.11.x for 21.11.07
Comment 10 Victor Grousset/tuxayo 2022-06-26 00:10:30 UTC
It looks like missing dependencies for 21.05.x, it doesn't seem affected, no backport.

Nothing to document, marking resolved.
Comment 11 Arthur Suzuki 2022-07-20 07:57:31 UTC
This one was actually reverted on 21.11.10, I didn't reproduced the bug.