This seems to effect current master, but not 22.05.x To test: 1. Try placing hold 2. Everything seems to work but no hold gets placed. I am not finding anything in the error logs.
Created attachment 135611 [details] [review] Bug 30892: (bug 30742 follow-up) Send single bib as a holdable bib
Created attachment 135613 [details] [review] Bug 30892: (bug 30742 follow-up) Send single bib as a holdable bib Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Test plan here is a little sparse - for example I can only guess from the code that we are looking at at the staff interface here. I'll give it a go, but please do better with commit messages!
Created attachment 135725 [details] [review] Bug 30892: (bug 30742 follow-up) Send single bib as a holdable bib To test: 1. Try placing hold 2. Everything seems to work but no hold gets placed. 3. Apply patch 4. Verify holds are no placed correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.01
(In reply to Lucas Gass from comment #0) > This seems to effect current master, but not 22.05.x Hi Lucas, does this need to be backported?
(In reply to Katrin Fischer from comment #7) > (In reply to Lucas Gass from comment #0) > > This seems to effect current master, but not 22.05.x > > Hi Lucas, does this need to be backported? Cait, I think 22.05 needs it because I choose to backport Bug 30742
That makes sense, thx!
This one depends on 30742 which I couldn't apply on 21.11.x (lots of conflicts).