+++ This bug was initially created as a clone of Bug #30744 +++ To reproduce: 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC.
Created attachment 135761 [details] [review] Bug 30918: Allow passing filtered record to get_marc_notes This patch does the absolute bare minimum to prevent private notes from appearing on the OPAC. Test plan 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC. 8. Apply patch 9. Confirm the non-public note is no longer visible
Created attachment 135772 [details] [review] Bug 30918: Allow passing filtered record to get_marc_notes This patch does the absolute bare minimum to prevent private notes from appearing on the OPAC. Test plan 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC. 8. Apply patch 9. Confirm the non-public note is no longer visible Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I was going to write that we should do that in get_marc_notes but just noticed you did it on bug 30744. Why this patch then?
I created this bug after bug 30744 after it was requested there that I do something super simple for backport. So this is the simple first step and then I try to do a more thorough cleanup job of the code in the other bug (and follow-up bugs atop it)
Also, as dcook mentioned.. it was a little sub-optimal that we're fetching the metadata record twice to filter twice.. by allowing it to be passed along we may gain a minor performance improvement (unmeasured).
Created attachment 136778 [details] [review] Bug 30918: Allow passing filtered record to get_marc_notes This patch does the absolute bare minimum to prevent private notes from appearing on the OPAC. Test plan 1. Go to Koha Administration -> Koha bibliographic frameworks 2. View the MARC structure for your BKS framework (or something else) 3. Search for tag 583, edit subfields 4. Go to subfield 'x' - nonpublic note. Confirm the OPAC visibility checkbox is UNCHECKED. 5. Edit or create a record using the BKS framework. Put a note in the 583$x. 6. View this record in the OPAC 7. Go to the Title notes tab. Confirm the non-public note is showing, even though the framework says it should not be visible via the OPAC. 8. Apply patch 9. Confirm the non-public note is no longer visible Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.04
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.
Will backport because it's a dependency of bug 30744
Can't backport to 21.05.x: can't solve a conflict (I can but the page crashes sooo...). If there is an interest in having this backported (to have bug 30744), please submit a patch for 21.05.
By the way, it has been backported to 21.11.x for v21.11.11
Last month to get an opportunity to have this backported to 21.05.x if that is still needed and if someone can make a patch for 21.05.x