Suspecting 26346 ..
Try to entries to a list from a detail page in opac or staff. Note that currently you cant even add items from search results in opac, since that one is broken too for Zebra. *sigh*
And enable OpacAllowpubliclistcreation or so
var "category" is not retrieved from opac/opac-addbybiblionumber.pl commit adc3772204f3c9d5f95866c1e4b90d81198671fc Bug 28959: (follow-up) Adjust all places in which 'category' was used -my $category = $query->param('category'); +my $public = $query->param('public');
Just noting: I checked out the v21.11.00 tag and found that this bug can be replicated - at least when creating a public list by adding items to new list on the staff client. I have not tested on the OPAC. Bug 26346 was not pushed to 21.11.00. Also, if you check out commit c9fc07aee3bc9b60a856b1b873ec731a31c2bc8a which the commit before bug 28959 was pushed this buggy behaviour cannot be replicated in the staff client. Therefore I do not think this bug was caused by 26346
(In reply to Alex Buckley from comment #4) > Just noting: I checked out the v21.11.00 tag and found that this bug can be > replicated - at least when creating a public list by adding items to new > list on the staff client. I have not tested on the OPAC. > > Bug 26346 was not pushed to 21.11.00. > > Also, if you check out commit c9fc07aee3bc9b60a856b1b873ec731a31c2bc8a which > the commit before bug 28959 was pushed this buggy behaviour cannot be > replicated in the staff client. > > Therefore I do not think this bug was caused by 26346 You are right.
(In reply to Marcel de Rooy from comment #5) > (In reply to Alex Buckley from comment #4) > > Just noting: I checked out the v21.11.00 tag and found that this bug can be > > replicated - at least when creating a public list by adding items to new > > list on the staff client. I have not tested on the OPAC. > > > > Bug 26346 was not pushed to 21.11.00. > > > > Also, if you check out commit c9fc07aee3bc9b60a856b1b873ec731a31c2bc8a which > > the commit before bug 28959 was pushed this buggy behaviour cannot be > > replicated in the staff client. > > > > Therefore I do not think this bug was caused by 26346 > > You are right. Thank you
No patch? :(
Created attachment 136337 [details] [review] Bug 30925: Fix category parameter for addbybiblionumber In bug 28959 category was replaced in favor of public. But unfortunately a few places were missed. This fixes the addbybiblionumber templates. Test plan: Add a biblio to a list from the search results using the Add to or Add to list button on OPAC/intranet. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: SO
(In reply to Katrin Fischer from comment #7) > No patch? :( Tomas would have a look.. But now I did.
(In reply to Marcel de Rooy from comment #10) > (In reply to Katrin Fischer from comment #7) > > No patch? :( > > Tomas would have a look.. But now I did. Thanks, I was just about to as Katrin's email reminded me of this.
Created attachment 136373 [details] [review] Bug 30925: Fix category parameter for addbybiblionumber In bug 28959 category was replaced in favor of public. But unfortunately a few places were missed. This fixes the addbybiblionumber templates. Test plan: Add a biblio to a list from the search results using the Add to or Add to list button on OPAC/intranet. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.03
backported to 21.11.x for 21.11.11
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.
Not sure what needed to be documented here. It's a fix of a faulty behaviour, not a new behaviour... I'll close it, but feel free to reopen with clarification if needed.