I propose to reformat the authority detail template in the staff interface (authorities/detail.tt) so that it has consistent spacing and indentation.
Created attachment 135911 [details] [review] Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy.
Created attachment 135912 [details] [review] Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 136315 [details] [review] Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 136316 [details] [review] Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 136318 [details] [review] Bug 30936: Reindent authority detail template This patch updates the authority detail template so that indentation is consistent. To test, apply the patch and go to Authorities. - Locate an authority record and view the detail page. - Everything should look correct, with working numbered tabs. - If the AuthDisplayHierarchy preference is enabled, you should see a collapsible tree of elements in the authority hierarchy. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 136319 [details] [review] Bug 30936: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.04
conflicts when trying to apply to 21.11.x. please provide backport if needed.