Bug 30942 - Optionally hide recalls button on detail page when no recall can be placed
Summary: Optionally hide recalls button on detail page when no recall can be placed
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
Depends on:
Blocks: 29734
  Show dependency treegraph
Reported: 2022-06-10 13:36 UTC by Martin Renvoize
Modified: 2023-01-20 22:38 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-06-10 13:36:40 UTC
The 'Place recall' button always seems to be present, even when there's no items on loan.
Comment 1 Owen Leonard 2022-06-14 17:34:00 UTC
The same seems to be true of article requests.
Comment 2 Katrin Fischer 2022-06-14 21:11:30 UTC
For article requests it makes sense as it's basically a document delivery where you go to the shelf, grab the serial volume or whatever and copy the requested article for the user.

For recalls it might be depending on the new 'allow on-shelf recalls' setting in the circulation rules.
Comment 3 Owen Leonard 2022-06-15 12:10:01 UTC
I mention it because I can click on the "Request article" in a page of OPAC search results and get a message, "No article requests can be made for this record." I think that's a good reason to handle it more gracefully for the patrons.
Comment 4 Martin Renvoize 2022-06-16 15:08:31 UTC
OK.. I find the notion of 'on-shelf recalls' weird then.. I totally don't understand this new feature... it just feels like copy of the existing holds functionality.

As for article requests I understand why you'd want that always there.. or rather there for anything that should be allowed an article request regardless of it's current availability... it's more about copyright and scanning of materials that would mean it's unavailable for article requests I would think?
Comment 5 Katrin Fischer 2022-06-16 15:57:46 UTC
There was a longer discussion about performance etc. for showing the Article request link when there is actually not an article request possible when  ArticleRequestsLinkControl was added. Looking into the bug for that one might explain more.

For recalls Aleisha might be able to explain next week.
Comment 6 Aleisha Amohia 2022-06-20 21:38:12 UTC
The button to 'Place recall' always shows, because the libraries who were sponsoring the development of this feature for the past few years before it was upstreamed wanted it to be there.

This way, users would know the library used recalls, and then be blocked if a particular record could not be recalled, and they could place a reserve instead.

As I've said many times before, recalls is not the same as holds, and if you look at the code, there are many differences. Recalls could never use the same code as holds without creating if/else conditions literally everywhere and turning Koha into a very non-scalable, hard to modify, hard to test, system. You don't want to potentially break holds by modifying recalls, and vice versa - they are different services in a library.

You're welcome to write a development that wraps this button in a syspref, but this isn't a bug, so please don't remove the ability to have the button there if there aren't recallable items.
Comment 7 Martin Renvoize 2022-06-21 05:57:29 UTC
Can we have a full description of what recalls is and how to use it for the manual please.  It's really unclear to me what the differences are and what use cases it fulfills.
Comment 8 Katrin Fischer 2022-06-21 06:24:06 UTC
I think something for the manual would be great and I'd also be very interested to hear how this is used and the thinking process behind it. It's a different thing to the recalls I know and I'd like to understand better when testing and QA'ing any additions in the future, to make sure we have things in mind like the button behavior you pointed out.
Comment 9 Aleisha Amohia 2022-06-21 21:10:25 UTC
This mostly covers what is now in upstream, it's been available on the wiki for years: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls

Outside of this we have also further developed recalls to be on the staff side for a different library. I'd love to have time to upstream that.
Comment 10 David Nind 2022-06-21 21:37:59 UTC
(In reply to Katrin Fischer from comment #8)
> I think something for the manual would be great and I'd also be very

Sorry, my fault about the manual. I have a draft and will get this ready for publishing as soon as I can.
Comment 11 Aleisha Amohia 2022-06-21 21:48:38 UTC
Thanks David. If you need clarification on details etc feel free to email me or the Catalyst Koha team.
Comment 12 David Nind 2022-06-21 21:50:22 UTC
(In reply to Aleisha Amohia from comment #11)
> Thanks David. If you need clarification on details etc feel free to email me
> or the Catalyst Koha team.

Thanks Aleisha. Will make a preview available for review and feedback.